A new compute_pointing_directions function#3345
Merged
vineetbansal merged 1 commit intoJul 24, 2026
Merged
Conversation
…ions Generalize the Lo L1C pointing-direction geometry so it can be reused by other products (e.g. the l1c quickmap) without duplicating the DPS az/el -> sky transform.
vineetbansal
merged commit Jul 24, 2026
cec542a
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new
compute_pointing_directionsfunction.When working on the Lo map product, I'm realizing that I need to compute pointing directions without needing the DataArrays that the
set_pointing_directionsfunction is currently returning, so I'm breaking up the function into two.So far I'm finding that I also need to customize the
spin_angles,off_anglesandto_framewhen I call this new function (though I might be mistaken as I dig further in), so I've exposed them as parameters.