Dependency jsons present locally are not downloaded#3344
Merged
vineetbansal merged 2 commits intoJul 24, 2026
Conversation
tmplummer
reviewed
Jul 23, 2026
Contributor
There was a problem hiding this comment.
Can you please add to the dependency_help string to clarify that if the json file doesn't exist locally, it will attempt to be downloaded using imap-data-access?
tmplummer
reviewed
Jul 23, 2026
tmplummer
left a comment
tmplummer
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just the one nit about updating the argparse help string.
tmplummer
approved these changes
Jul 23, 2026
vineetbansal
merged commit Jul 24, 2026
7c51269
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2889
During development of processing steps that need to be tested locally before a PR to
sds-data-manager, the ability to test against a locally available (and hand-coded) dependency json is invaluable. This adds the ability to do so.