News 48342: Remove Unused News Block Helpers - #12091
Open
matheuszych wants to merge 1 commit into
Open
matheuszych wants to merge 1 commit into
matheuszych wants to merge 1 commit into
Conversation
See: https://mantis.ilias.de/view.php?id=48342 The methods `ilNewsItemGUI::getHTML()` and `getNewsForContextBlock()` were unreachable dead code. News block rendering is handled by `ilNewsForContextBlockGUI`, and the news overview uses `getNewsForContextTable()`. The language variable `news_block_news_for_context` was only referenced by the removed code and has been deleted from all language files.
dsstrassner
added
bugfix
php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=48342
The methods
ilNewsItemGUI::getHTML()andgetNewsForContextBlock()were unreachable dead code. News block rendering is handled byilNewsForContextBlockGUI, and the news overview usesgetNewsForContextTable(). The language variablenews_block_news_for_contextwas only referenced by the removed code and has been deleted from all language files./cc @thojou