Skip to content

fix(sqlstore): read a keyed grant listing by its primary key - #880

Merged
osanderson merged 2 commits into
mainfrom
fix/sqlstore-grant-list-by-key
Nov 19, 2026
Merged

osanderson merged 2 commits into
mainfrom
fix/sqlstore-grant-list-by-key

Conversation

@osanderson

Copy link
Copy Markdown
Collaborator

FAPIgo v0.77.0 (#878) confirms a refresh token's grant with GrantListing.Key set. A store that honours it reads only that entry, but sqlstore ignored Key. So each refresh-token issuance still fetched and decrypted every unexpired grant of the subject, and that set grows with each completed authorization, since FAPI forbids refresh-token rotation.

Change

  • ListGrants with Key set reads WHERE entry_key = ? AND subject_key = ? AND expires_at > ?, a primary-key lookup. It is still scoped to the subject, so another user's entry is never returned, and to unexpired entries.
  • A Key that can't be stored is answered as unknown, as DeleteGrant already does.
  • go.mod now requires fapigo v0.77.0, the first release with GrantListing.Key.

Without Key, listing is unchanged.

Tests

  • TestGrantRegistryListsByKeyAlone (SQLite and Postgres) checks that a keyed listing returns that entry alone. It fails if ListGrants ignores Key.
  • The storage contract's ListByKey case now runs against sqlstore's real keyed read.
  • checkUnstorableKeyReads covers an unstorable Key.

🤖 Generated with Claude Code

FAPIgo v0.77.0 passes GrantListing.Key when it confirms a refresh
token's grant, so the check needn't list the subject's other grants.
sqlstore ignored Key, so each refresh-token issuance still fetched and
decrypted every unexpired grant of the subject, a cost that grows with
each completed authorization.

ListGrants now reads only the entry with that key, still scoped to the
subject and to unexpired entries, and answers a key it can't store as
unknown. sqlstore now requires fapigo v0.77.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

The sqlstore module it replaces locally now requires fapigo v0.77.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@osanderson
osanderson merged commit 8be886c into main Nov 19, 2026
29 checks passed
@osanderson
osanderson deleted the fix/sqlstore-grant-list-by-key branch November 19, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant