Repository navigation
fix(sqlstore): read a keyed grant listing by its primary key - #880
Merged
Merged
Conversation
FAPIgo v0.77.0 passes GrantListing.Key when it confirms a refresh token's grant, so the check needn't list the subject's other grants. sqlstore ignored Key, so each refresh-token issuance still fetched and decrypted every unexpired grant of the subject, a cost that grows with each completed authorization. ListGrants now reads only the entry with that key, still scoped to the subject and to unexpired entries, and answers a key it can't store as unknown. sqlstore now requires fapigo v0.77.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The sqlstore module it replaces locally now requires fapigo v0.77.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



FAPIgo v0.77.0 (#878) confirms a refresh token's grant with
GrantListing.Keyset. A store that honours it reads only that entry, but sqlstore ignoredKey. So each refresh-token issuance still fetched and decrypted every unexpired grant of the subject, and that set grows with each completed authorization, since FAPI forbids refresh-token rotation.Change
ListGrantswithKeyset readsWHERE entry_key = ? AND subject_key = ? AND expires_at > ?, a primary-key lookup. It is still scoped to the subject, so another user's entry is never returned, and to unexpired entries.Keythat can't be stored is answered as unknown, asDeleteGrantalready does.go.modnow requires fapigo v0.77.0, the first release withGrantListing.Key.Without
Key, listing is unchanged.Tests
TestGrantRegistryListsByKeyAlone(SQLite and Postgres) checks that a keyed listing returns that entry alone. It fails ifListGrantsignoresKey.ListByKeycase now runs against sqlstore's real keyed read.checkUnstorableKeyReadscovers an unstorableKey.🤖 Generated with Claude Code