Skip to content

build: apply least privilege to workflows - #863

Merged
Andris28 merged 3 commits into
mainfrom
fa/apply-least-privilege-to-workflow
Oct 8, 2026
Merged

Andris28 merged 3 commits into
mainfrom
fa/apply-least-privilege-to-workflow

Conversation

@Andris28

@Andris28 Andris28 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

PR summary

In this commit we add least privilege principle the workflow permissions.

ref.: #862

PR Checklist

General checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Dependencies have been updated as needed
  • .secrets.baseline has been updated as needed
  • npm run update-utilities has been run if any files in packages/utilities/src have been updated

Checklist for adding a new validation rule:

  • Added new validation rule definition (packages/ruleset/src/rules/*.js, index.js)
  • If necessary, added new validation rule implementation (packages/ruleset/src/functions/*.js, updated index.js)
  • Added new rule to default configuration (packages/ruleset/src/ibm-oas.js)
  • Added tests for new rule (packages/ruleset/test/*.test.js)
  • Added docs for new rule (docs/ibm-cloud-rules.md)
  • Added scoring rubric entry for new rule (packages/validator/src/scoring-tool/rubric.js)

Signed-off-by: András Felleg <afelleg@gmail.com>
@Andris28
Andris28 requested review from diatrcz and pyrooka October 7, 2026 14:37

@pyrooka pyrooka left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just left one security related suggestion.

(Would be nice to use a bit more human readable PR title. :P)

branches: ['**']
workflow_dispatch:
# Allow workflow to be triggered manually.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
permissions: {}

Having a top level permission that denies everything is a good practice to prevent jobs (accidentally, without permissions set) to get access everything.

Signed-off-by: András Felleg <afelleg@gmail.com>
Signed-off-by: András Felleg <afelleg@gmail.com>
@Andris28 Andris28 changed the title build: apply-least-privilege-to-workflows build: apply least privilege to workflows Oct 8, 2026
@Andris28
Andris28 merged commit cf6ec48 into main Oct 8, 2026
12 checks passed
@Andris28
Andris28 deleted the fa/apply-least-privilege-to-workflow branch October 8, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants