Repository navigation
Conversation
The estimator allowlist had no sktime transformers and only one tabular estimator, so the advertised recipe features always failed with "... is not an allowed estimator class": - forecasting `transforms` (e.g. ExponentTransformer, Detrender) - tabular `sktime_class` transforms (e.g. Catch22, MiniRocket) - `tsfm_regression` (no regressor was allowed) - tabular classification/clustering other than RandomForestClassifier Add the series/panel transformers, the trend forecasters and sklearn scalers they nest, and common sklearn regressors, classifiers and KMeans. None take a callable, file path or pickle. Tests cover a transformed forecast, a Catch22 -> RandomForestRegressor regression, and that every allowlisted path imports. Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Resolve the ALLOWED_CLASSES conflict with 08e817b as the union: keep that commit's groups as-is and add the remaining transformers, scalers and tabular estimators from this branch to the matching group. Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
08e817b adds test_forecasting_transforms_still_run and test_tabular_regression_still_runs; keep only the allowlist import check. Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
ShuxinLin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #633 (review comment on
resolver.py:33). #633's 08e817b already allowlists the core forecasting transforms and addsRandomForestRegressor,GradientBoostingRegressor,RidgeandKMeans. This PR adds the remaining common estimators that worked before #633 and are still refused there:run_tabular_recipeclassification with anything other thanRandomForestClassifierRocket/MiniRocketMultivariatetabular transforms, and a few more series transformsFix Details
substrate/resolver.py: add 15 exact paths to 08e817b's groups:transforms:SqrtTransformer,ConditionalDeseasonalizer,HampelFilter,TrendForecaster(nested inDetrender/Imputer),RobustScaler(nested inTabularToSeriesAdaptor)Rocket,MiniRocketMultivariateExtraTreesRegressor,LinearRegression,Lasso,KNeighborsRegressor,ExtraTreesClassifier,GradientBoostingClassifier,LogisticRegression,KNeighborsClassifierNone of the additions take a callable, a file path or a pickle.
FunctionTransformerstays out.TSFreshFeatureExtractorstays out becausetsfreshis not installed. (SummaryTransformerfrom 08e817b is fine: sktime checkssummary_functionagainst a fixed list before calling pandas.)The branch merges the current #633 head. The conflict in
ALLOWED_CLASSESwas resolved as the union, keeping 08e817b's lines and grouping as they are.Impact on Benchmarking
Related Issues
Verification Steps
uv run pytest src/servers/tsfm/tests: 153 passed.test_every_allowed_class_importsimports everyALLOWED_CLASSESpath, which catches typos or sktime path drift. My earlier transform/regression tests were dropped because 08e817b adds equivalent ones.run_recipe/run_tabular_recipe.Checklist