Repository navigation
Extract the protected CloudFront Geo baseline #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChristianPavilonis
wants to merge
20
commits into
baseline/native-aws-20261110
from
baseline/protected-geo-20261110
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e15d3b2
Extract the protected CloudFront Geo baseline
ChristianPavilonis fb8b2a5
Carry the native toolchain lint correction into Geo
ChristianPavilonis 6003fa6
Carry the startup probe correction through the compatible baseline
ChristianPavilonis affb0d0
Carry the browser CI host compatibility fix through the baseline
ChristianPavilonis 9a0266f
Carry the tagged EdgeZero snapshot through the stack
ChristianPavilonis 0ae96ef
Carry the monthly EdgeZero tag through the stack
ChristianPavilonis e0ee5ac
Carry protected CloudFront Geo onto the direct EdgeZero cutover
ChristianPavilonis 38f68a5
Retain the owning native startup fixture correction
ChristianPavilonis 633a0c7
Migrate current Fastly Geo fixtures to partial location data
ChristianPavilonis 1a914d6
Keep the trace parity fixture honest about partial Geo
ChristianPavilonis ee27f39
Retain the concurrent cutover documentation closeout
ChristianPavilonis 006fa9d
Retain prepared native development documentation
ChristianPavilonis efc416a
Retain current main validation and mediator fallback
ChristianPavilonis d9e7727
Retain the Cargo target-aware cache harness
ChristianPavilonis 857611d
Retain target-aware GPT bundle lookup for the cache fixture
ChristianPavilonis 6bc85ab
Carry hosted qualification fixes through PR 1532
ChristianPavilonis 5c331c2
Carry hosted qualification fixes through PR 1532
ChristianPavilonis d95730c
Carry hosted qualification fixes through PR 1532
ChristianPavilonis 713bdd9
Carry hosted qualification fixes through PR 1532
ChristianPavilonis 852b875
Carry hosted qualification fixes through PR 1532
ChristianPavilonis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
♻️ refactor: Geo header clearing now lives in two places with different coverage:
geoisSome, this loop clears six headers andGeoInfo::set_response_headersclears the same six again.apply_finalize_headers(crates/trusted-server-adapter-fastly/src/middleware.rs:211-218) never clears them in itsNonebranch, so an origin-suppliedx-geo-countrysurvives next tox-geo-info-available: falseon Fastly but not on Axum.One core helper used by both adapters would remove the duplication and the divergence:
Apply manually: this can't be a one-click suggestion because it spans core and both adapters.