Skip to content

feat(axum): add safe diagnostics and trusted proxy metadata #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChristianPavilonis wants to merge 12 commits into from
Open

feat(axum): add safe diagnostics and trusted proxy metadata #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0769cbf
feat(axum): add safe diagnostics and trusted proxy metadata
ChristianPavilonis Oct 7, 2026
61fc149
fix(axum): keep diagnostics behind its native runtime feature
ChristianPavilonis Nov 10, 2026
3cb7f85
Merge verified lower-stack fixture lock
ChristianPavilonis Nov 10, 2026
9fa1666
fix(ci): align diagnostic fixture locks with required dependencies
ChristianPavilonis Nov 10, 2026
bee8dc0
Merge corrected lower-stack feature and CI contracts
ChristianPavilonis Nov 10, 2026
3b52b80
fix(axum): separate trusted ingress from retired proxy transport
ChristianPavilonis Nov 10, 2026
ef42131
Merge managed demo logging regression alignment
ChristianPavilonis Nov 10, 2026
5bbff2b
Merge native-only scaffold correction into diagnostics stack
ChristianPavilonis Nov 10, 2026
027e161
Prepare authenticated head facts before stripping forwarded fields
ChristianPavilonis Nov 12, 2026
3708ffa
Carry prepared-router installation through the review stack
ChristianPavilonis Nov 12, 2026
daae624
Merge current parent repairs into PR 409
ChristianPavilonis Nov 12, 2026
31f46bd
Retain callback-scope fixture repair in PR 409
ChristianPavilonis Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,15 @@ fern = "0.7"
flate2 = { version = "=1.1.9", default-features = false, features = ["rust_backend"] }
futures = { version = "0.3", features = ["std", "executor"] }
futures-util = { version = "0.3", features = ["alloc", "io"] }
getrandom = "=0.4.2"

@aram356 aram356 Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 New exact pins downgrade the app-demo lock and pull in a second wasm-tools tree

getrandom = "=0.4.2" (and ipnet = "=2.12.0" at line 74) are new in this PR; the PR body calls them "existing exact workspace requirements". Because app-demo resolves these through the path dependency, examples/app-demo/Cargo.lock is forced from getrandom 0.4.3 → 0.4.2 and ipnet 2.12.2 → 2.12.0. getrandom 0.4.2 depends on wasip2 + wasip3 0.4.0+wasi-0.3.0-rc-2026-01-06, which drags back wit-bindgen 0.51, wasm-encoder/wasmparser/wit-parser/wit-component/wasm-metadata 0.244, prettyplease 0.2.37, hashbrown 0.15.5 and foldhash 0.1.5. That is most of the ~218-line app-demo lock diff. The pin also blocks the root from moving to 0.4.3, which drops the wasip3 RC dependency.

The plan (line 113) specifies caret "0.4.2"/"2.12", and plan line 375 says "No package version changed"; neither matches.

Suggestion: use caret requirements (or pin =0.4.3 / =2.12.2 and update the root lock), then regenerate the app-demo lock so it only gains the two new edges.

handlebars = "6"
http = "=1.4.2"
http-body = "1"
http-body-util = "0.1"
httparse = "=1.10.1"
hyper = { version = "=1.12.0", features = ["http1", "server"] }
hyper-util = { version = "0.1", features = ["tokio"] }
ipnet = "=2.12.0"
log = "0.4"
libc = "0.2"
miniz_oxide = { version = "=0.8.9", default-features = false, features = ["simd", "with-alloc"] }
Expand All @@ -90,6 +92,7 @@ simd-adler32 = { version = "=0.3.9", default-features = false }
# file (`<spin.toml dir>/.spin/sqlite_key_value.db`) using the schema
# vendored from spinframework/spin's `crates/key-value-spin/src/store.rs`.
rusqlite = { version = "0.40", default-features = false, features = ["bundled"] }
rustls = { version = "=0.23.46", default-features = false, features = ["std", "tls12", "aws_lc_rs"] }
ryu = "1"
serde = { version = "1", features = ["derive"] }
serde_json = "=1.0.150"
Expand All @@ -113,6 +116,7 @@ tempfile = "3"
toml_edit = "0.25"
thiserror = "2"
tokio = { version = "1", features = ["io-util", "macros", "net", "rt-multi-thread", "signal", "sync", "time"] }
tokio-rustls = { version = "=0.26.4", default-features = false, features = ["tls12", "aws_lc_rs"] }
trybuild = "1"
toml = { version = "1.1" }
tower = { version = "0.5", features = ["util"] }
Expand Down
6 changes: 6 additions & 0 deletions crates/edgezero-adapter-axum/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ axum = [
"dep:http-body",
"dep:hyper",
"dep:hyper-util",
"dep:ipnet",
"dep:getrandom",
"dep:mime",
"dep:reqwest",
"dep:redb",
Expand All @@ -47,10 +49,12 @@ bytes = { workspace = true }
ctor = { workspace = true, optional = true }
futures = { workspace = true }
futures-util = { workspace = true, optional = true }
getrandom = { workspace = true, optional = true }
http = { workspace = true }
http-body = { workspace = true, optional = true }
hyper = { workspace = true, optional = true }
hyper-util = { workspace = true, optional = true }
ipnet = { workspace = true, optional = true }
log = { workspace = true }
mime = { workspace = true, optional = true }
redb = { workspace = true, optional = true }
Expand Down Expand Up @@ -85,6 +89,8 @@ http-body = { workspace = true }
httparse = { workspace = true }
hyper = { workspace = true }
hyper-util = { workspace = true }
rustls = { workspace = true }
serde = { workspace = true }
tempfile = { workspace = true }
tokio = { workspace = true, features = ["io-util", "macros", "net", "rt", "rt-multi-thread", "test-util"] }
tokio-rustls = { workspace = true }
Loading
Loading