Repository navigation
chore(git): stop ignoring every path that starts with an underscore - #331
Merged
Merged
Conversation
The bare _* rule matched no tracked file and hid six Python __init__.py files, so they existed in working trees but never in clones, tags or the images built from them. Those packages only loaded as namespace packages. Found when a clean export of 3.8.0 would have deleted them from the server. Replace it with what it was catching on purpose: __pycache__, bytecode and the PHPUnit coverage report. The six files are committed as they were. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitignorehad a bare_*, which matches any file or folder starting with an underscore, anywhere in the repo. It matched no tracked file, but it hid these six files:parsers/__init__.pyservices/nlp/app/__init__.pyservices/nlp/app/routers/__init__.pyservices/nlp/app/services/__init__.pyservices/nlp/app/services/lemmatizers/__init__.pyservices/nlp/app/services/parsers/__init__.pyThey exist in working trees but never reached clones, tags or CI-built images, where those folders load as namespace packages. It came to light when a clean export of 3.8.0 for deployment would have deleted them from the server. Nothing broke, because
main.pyimports submodules explicitly, but a future__init__.pywith real logic would have vanished silently.Change
.gitignore:_*is replaced with__pycache__/,*.py[cod]and/coverage_report/. I compared the full ignored-file list before and after:coverage_report/also relied on_*for its_css,_iconsand_jsfolders, hence its own rule. The six files above are now the only paths that stop being ignored.No application code changes.
🤖 Generated with Claude Code