Skip to content

Make the shipped code portable - #52

Merged
caguero merged 13 commits into
caguero/joy_calibrate_owns_joy_nodefrom
caguero/portability
Sep 1, 2026
Merged

Make the shipped code portable#52
caguero merged 13 commits into
caguero/joy_calibrate_owns_joy_nodefrom
caguero/portability

Conversation

@caguero

@caguero caguero commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

This patch removes some platform specific code.

Built on top of #47.

How to test it?

ros2 launch bluerov2_gazebo sim.launch.xml
ros2 topic echo /robot_description --once --qos-durability transient_local --qos-reliability reliable | head -1
ros2 topic pub /bluerov2/thruster_5/thrust std_msgs/msg/Float64 "data: -10.0" -1   # the vehicle descends

Same for the BlueBoat (blueboat_gazebo, /blueboat/motor_port/thrust).

caguero added 13 commits September 1, 2026 14:29
@caguero
Guard the joy_map helper spawn and curses import per platform
2930c14 
Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
@caguero
Generate the robot_state_publisher params file instead of shelling ou…
4c7ad30 
…t to cat in the launches

Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
@caguero
State the portability conventions and the deliberate Linux scope of t…
63de97e 
…he test tooling

Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
@caguero
Drop the contributing portability note
f93a0df 
Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
@caguero
Merge branch 'caguero/joy_calibrate_owns_joy_node' into caguero/porta…
c136050 
…bility
@caguero
Simplify the helper spawn per platform and run the teleop unit tests …
1ce568d 
…on macOS and Windows in CI

Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
@caguero
Point the portability workflow at the robostack jazzy channel
e449855 
Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
@caguero
Build the teleop package in an isolated workspace on the portability …
5314377 
…runners

Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
@caguero
Fake the joy prefix in the portability tests so they need no joy package
2f79c7b 
Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
@caguero
Compute native paths for the portability test environment
4917500 
Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
@caguero
Trigger the portability workflow on pull requests touching the teleop…
28ed6e1 
… package

Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
@caguero
Drop the macOS and Windows CI workflow
66b8c12 
Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
@caguero
Drop the platform spawn tests
34432b5 
Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
@caguero
caguero merged commit 386b4c3 into caguero/joy_calibrate_owns_joy_node Sep 1, 2026
2 checks passed
@caguero
caguero deleted the caguero/portability branch September 1, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caguero @ahcorde