Skip to content

Fix two lint configuration traps #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
StylianosGakis wants to merge 2 commits into from
+10 −1
Draft

Fix two lint configuration traps #3121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f585039
chore: only set the lint baseline when the module has one
StylianosGakis Sep 3, 2026
dab15bf
chore: stop lint from reporting version catalog staleness
StylianosGakis Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion build-logic/convention/src/main/kotlin/HedvigLintConventionPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@ class HedvigLintConventionPlugin : Plugin<Project> {
}

private fun Lint.configure(lintXmlFile: File, lintBaselineFile: File) {
baseline = lintBaselineFile
// Lint aborts the build whenever it has to create a baseline, even when it found nothing to put in
// one, and the baseline it leaves behind then suppresses real errors on the next run. A module opts
// in by committing the file: create it empty, then fill it with `updateLintBaseline`.
baseline = lintBaselineFile.takeIf(File::exists)
lintConfig = lintXmlFile
xmlReport = true
}
6 changes: 6 additions & 0 deletions hedvig-lint/lint.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@
config entry for a check absent from a given module isn't flagged. -->
<issue id="UnknownIssueId" severity="ignore" />

<!-- Renovate (renovate.json) owns dependency freshness, so lint's version-staleness notices are
duplicate signal. They also resolve against the shared root gradle/libs.versions.toml rather
than the module being linted, so they report identically no matter which module runs lint. -->
<issue id="GradleDependency" severity="ignore" />
<issue id="NewerVersionAvailable" severity="ignore" />

<issue id="ButtonCase" severity="ignore" />
<issue id="TypographyDashes" severity="ignore" />
<issue id="TypographyEllipsis" severity="ignore" />
Expand Down
Loading