Fix the ktlint failures already present on develop - #3111
Draft
StylianosGakis wants to merge 1 commit into
Draft
Conversation
StylianosGakis
force-pushed
the
chore/fix-ktlint-formatting
branch
from
August 28, 2026 20:55
0a70e05 to
dbc532e
Compare
StylianosGakis
changed the base branch from
chore/namespace-import-ktlint-rule
to
develop
August 28, 2026 20:55
`./gradlew ktlintCheck` fails on develop in two modules, 37 errors, none of them related to any in-flight work. Left alone it is a trap: any PR that touches ktlint config looks like it broke CI when it did not. YourInfoTab.kt is purely `formatKotlin` output: an if/else given braces and a newline, and a function signature collapsed onto one line. TerminationRedirectionDestination.kt needed a manual fix, since standard:max-line-length is not auto-fixable. The same 127 character description string appears in two previews and is now split across two literals.
StylianosGakis
force-pushed
the
chore/fix-ktlint-formatting
branch
from
September 3, 2026 08:31
dbc532e to
d72a3c2
Compare
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
developgreen just to make the rest of the stack cleaner🤖 AI description:
Bottom of stack #3125. Independent of the rest of it in content, but it comes first deliberately: the layers above add a new ktlint rule, and this makes
ktlintCheckactually pass so that rule can be trusted.Why
./gradlew ktlintCheckfails ondeveloptoday, in two modules, with 37 errors unrelated to any in-flight work:standard:indentstandard:function-signaturestandard:multiline-if-elsestandard:max-line-lengthstandard:if-else-wrappingLeft alone it is a trap. Any PR that touches ktlint config looks like it broke CI when it didn't, which is exactly the situation the PRs above this one were in.
What changed
YourInfoTab.ktis purely./gradlew :feature-insurances:formatKotlinoutput. Ignoring whitespace it is an if/else given braces and a newline, plus a function signature collapsed onto one line. No behaviour change.TerminationRedirectionDestination.ktneeded a manual fix, sincestandard:max-line-lengthis not auto-fixable. The same 127 character description string appears in two previews and is now split across two literals.Verification
./gradlew ktlintCheckon this branch: BUILD SUCCESSFUL, 0 errors (down from 37).:feature-insurances:compileReleaseKotlinand:feature-terminate-insurance:compileReleaseKotlinboth succeed.ktlintCheckreports 0 errors there too, so the newhedvig:namespace-importrule is being judged against a genuinely clean tree.This commit was regenerated directly on current
developrather than rebased. Its entire content isformatKotlinoutput plus the one manual line split, so regenerating is exact and avoids resolving formatting conflicts by hand.