Skip to content

Fix the ktlint failures already present on develop - #3111

Draft
StylianosGakis wants to merge 1 commit into
developfrom
chore/fix-ktlint-formatting
Draft

Fix the ktlint failures already present on develop#3111
StylianosGakis wants to merge 1 commit into
developfrom
chore/fix-ktlint-formatting

Conversation

@StylianosGakis

@StylianosGakis StylianosGakis commented Aug 28, 2026

Copy link
Copy Markdown
Member

Makes develop green just to make the rest of the stack cleaner

🤖 AI description:

Bottom of stack #3125. Independent of the rest of it in content, but it comes first deliberately: the layers above add a new ktlint rule, and this makes ktlintCheck actually pass so that rule can be trusted.

Why

./gradlew ktlintCheck fails on develop today, in two modules, with 37 errors unrelated to any in-flight work:

Rule Count
standard:indent 27
standard:function-signature 4
standard:multiline-if-else 2
standard:max-line-length 2
standard:if-else-wrapping 2

Left alone it is a trap. Any PR that touches ktlint config looks like it broke CI when it didn't, which is exactly the situation the PRs above this one were in.

What changed

YourInfoTab.kt is purely ./gradlew :feature-insurances:formatKotlin output. Ignoring whitespace it is an if/else given braces and a newline, plus a function signature collapsed onto one line. No behaviour change.

TerminationRedirectionDestination.kt needed a manual fix, since standard:max-line-length is not auto-fixable. The same 127 character description string appears in two previews and is now split across two literals.

Verification

  • Repo-wide ./gradlew ktlintCheck on this branch: BUILD SUCCESSFUL, 0 errors (down from 37).
  • :feature-insurances:compileReleaseKotlin and :feature-terminate-insurance:compileReleaseKotlin both succeed.
  • Verified again from the top of the stack: ktlintCheck reports 0 errors there too, so the new hedvig:namespace-import rule is being judged against a genuinely clean tree.

This commit was regenerated directly on current develop rather than rebased. Its entire content is formatKotlin output plus the one manual line split, so regenerating is exact and avoids resolving formatting conflicts by hand.

@StylianosGakis
StylianosGakis force-pushed the chore/fix-ktlint-formatting branch from 0a70e05 to dbc532e Compare August 28, 2026 20:55
@StylianosGakis
StylianosGakis changed the base branch from chore/namespace-import-ktlint-rule to develop August 28, 2026 20:55
`./gradlew ktlintCheck` fails on develop in two modules, 37 errors, none of
them related to any in-flight work. Left alone it is a trap: any PR that
touches ktlint config looks like it broke CI when it did not.

YourInfoTab.kt is purely `formatKotlin` output: an if/else given braces and
a newline, and a function signature collapsed onto one line.

TerminationRedirectionDestination.kt needed a manual fix, since
standard:max-line-length is not auto-fixable. The same 127 character
description string appears in two previews and is now split across two
literals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant