[ci] Release from commit instead of branch name - #1387
Merged
Conversation
The branch may have moved since the package workflow started, so we need to make sure we release from the original commit that triggered the workflow to avoid multiple releases being created from the head of the master branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The branch may have moved since the package workflow started, so we need to make sure we release from the original commit that triggered the workflow to avoid multiple releases being created from the head of the master branch.
This was meant to be fixed in #1328, but it looks like ref is still the branch name instead of the commit id... the correct field is
sha:https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#github-context
NB: To fix the current state, we will also have to manually create a v4.3.158 tag from the latest commit in master and push it.