Repository navigation
Version 2.3 - #37
Merged
Merged
Version 2.3#37
Conversation
README: name VS Code's terminal among those tested, say the release copy isn't signed for AllSigned machines, show how to sort batch results back into input order, and say runspace results arrive in finish order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A nested list was cast to one string, joined with $OFS, so @('a', @('b', 'c'))
passed 'b c' as a single argument. ConvertTo-PkArgumentString, and so every
list in Arguments, now stops with an error naming the element, the same way a
hashtable in Arguments already does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On Windows PowerShell 5.1 a FileInfo from Get-ChildItem casts to its bare name, so Arguments = @($f, 'out.jxl') handed the program 'a.png' and it looked in the wrong folder; PowerShell 7 already gave the full path. A file or folder object, in a list, on its own, or passed to ConvertTo-PkArgumentString, is now its FullName on both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Version line:
ParallelKit.ps1's header says 2.3, ready for the v2.3 release. The README's Setup section says it describes 2.3 and later.README:
AllSigned) need the file signed with a certificate they trust; the release copy isn't signed.Resultsback into input order with a key of your own (Index = $n, thenSort-Object { $_.Command.Index }).-ResultHandlerin the order workers finish, so return something that identifies the job.Nested lists in
Arguments: a list inside the list was cast to one string, joined with$OFS, so@('a', @('b', 'c'))passedb cas one argument.ConvertTo-PkArgumentString, and so every list inArguments, now stops with an error naming the element, as a hashtable already does. The help and README say so.File objects in
Arguments: on Windows PowerShell 5.1 aGet-ChildItemresult cast to its bare name, so@($f, 'out.jxl')handed the programa.pngand it looked in the wrong folder. A file or folder object, in a list, on its own, or given toConvertTo-PkArgumentString, is now its full path on 5.1 and 7.Testing
Sort-Object { $_.Command.Index }pattern sorts a batch that finished 3,2,1,0 back to 0,1,2,3, underSet-StrictMode -Version Lateston Windows PowerShell 5.1 and PowerShell 7.Testing/hosts/check-host.ps1: VS Code's terminal (ConsoleHost) and the PowerShell extension's terminal (Visual Studio Code Host) both stopped the batch withaborted=True.StartError, andConvertTo-PkArgumentStringrefusing a nested hashtable) fail onmain.ConvertTo-PkArgumentString) fail on 5.1 onmain.ALL PASSED (392 assertions)on Windows PowerShell 5.1 and PowerShell 7, none skipped.🤖 Generated with Claude Code