Repository navigation
Fix drive-less paths and drain error reports; version 2.2 - #29
Merged
Merged
Conversation
A WorkingDirectory or FilePath like \tools or C:tools depends on a current drive and folder. The kit passed those straight to Windows, which used the process's rather than PowerShell's current location: the start failed, or the program ran in the wrong place. Only complete paths now go straight through; the rest are resolved the way PowerShell reads them. A non-terminating error in a worker that finished during an abort's drain wasn't reported, so a partial result looked fine. It now gets the same "Runspace error:" message as in the main loop. Three helpers with no callers are removed, along with a no-op assignment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
WorkingDirectoryorFilePathlike\toolsorC:toolswent straight to Windows, which used the process's drive and folder rather than PowerShell's current location. The start failed, or the program could run in the wrong place. This has been there since v2.1.Reproduced on Windows PowerShell 5.1 and PowerShell 7.
What changed
X:\...,\...) now go straight through. The rest are resolved the way PowerShell reads them, including from a registry location. AFilePathwith a drive and no folder (C:tool.exe) is included.Runspace error: ...the same way as the main loop.Set-PkRunActive,Set-PkConsoleQuickEditandTest-PkOwnAbortException, which had no callers, and a no-op assignment.Testing
WorkingDirectorywithout a complete path, aFilePathwithout a drive, and a non-terminating error during the drain. All 3 fail onmain's kit.ALL PASSED (291 assertions)on 5.1 and 7.🤖 Generated with Claude Code