迁移 ModpackHelper#findMinecraftDirectoryInManuallyCreatedModpack 到 kala-compress [Qwen3.7-Plus]#6465
迁移 ModpackHelper#findMinecraftDirectoryInManuallyCreatedModpack 到 kala-compress [Qwen3.7-Plus]#6465CiiLu wants to merge 2 commits into
ModpackHelper#findMinecraftDirectoryInManuallyCreatedModpack 到 kala-compress [Qwen3.7-Plus]#6465Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the modpack installation logic to use ArchiveFileTree instead of FileSystem when locating the Minecraft directory within manually created modpacks. The reviewer identified critical issues regarding character encoding and path separators: ignoring the charset parameter when opening zip files can lead to ZipException or incorrect directory parsing in non-UTF-8 environments (such as GBK on Windows). Additionally, converting the returned directory string to a Path object introduces platform-specific path separators (backslashes on Windows) which can break zip extraction utilities that expect forward slashes. The reviewer suggested updating the method signatures to accept and respect the charset parameter and keeping the subdirectory as a String.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c0dbb96e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| public static String findMinecraftDirectoryInManuallyCreatedModpack(String modpackName, Path zipPath) | ||
| throws IOException, UnsupportedModpackException { | ||
|
|
||
| try (ArchiveFileTree<?, ?> tree = ArchiveFileTree.open(zipPath)) { |
There was a problem hiding this comment.
For manually created ZIPs whose wrapper directory has non-UTF-8 entry names (for example, a GBK-named 整合包/.minecraft/versions/...), this opens the archive with ArchiveFileTree.open(zipPath), which constructs ZipArchiveReader without the charset selected by findSuitableEncoding. The detected prefix is therefore mojibake (or detection fails), while Unzipper subsequently decodes entries with the correct charset; no entries then match that prefix and the installer can create an empty game directory. Thread the charset through this helper and use it when creating the reader.
Useful? React with 👍 / 👎.
2 participants
No description provided.