Skip to content

为实例选择 popup 已选择的实例添加底色#6454

Open
CiiLu wants to merge 3 commits into
HMCL-dev:mainfrom
CiiLu:i
Open

为实例选择 popup 已选择的实例添加底色#6454
CiiLu wants to merge 3 commits into
HMCL-dev:mainfrom
CiiLu:i

Conversation

@CiiLu

@CiiLu CiiLu commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the 1+ label Jul 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates GameListPopupMenu.java to dynamically apply a "selected" CSS pseudo-class to the game list items based on their selection state. To support this, the rootPane variable was promoted to an instance field. The review feedback points out a minor syntax error where a double semicolon was introduced in the rootPane field declaration.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.


private final ImageContainer imageView;
private final TwoLineListItem content;
private final StackPane rootPane;;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

此处存在多余的分号(;;),应将其修改为单个分号。

Suggested change
private final StackPane rootPane;;
private final StackPane rootPane;

@Glavo

Glavo commented Jul 21, 2026

Copy link
Copy Markdown
Member

这 PR 问题太多了,请发布 PR 前自己检查一下 PR 的实际效果。

@github-actions github-actions Bot added 10+ and removed 1+ labels Jul 21, 2026
@Glavo

Glavo commented Jul 22, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: bc5b841ff7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Glavo

Glavo commented Jul 22, 2026

Copy link
Copy Markdown
Member
image

@CiiLu

CiiLu commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

我在两种系统环境均无法复现这个问题,不清楚该怎么修

[11:43:43] [@.Launcher.main/INFO] *** HMCL 3.17.SNAPSHOT ***
[11:43:43] [@.Launcher.main/INFO] Operating System: NixOS 26.11 (Zokor) (Linux 7.1.3)
[11:43:43] [@.Launcher.main/INFO] System Architecture: x86-64
[11:43:43] [@.Launcher.main/INFO] Native Encoding: UTF-8
[11:43:43] [@.Launcher.main/INFO] JNU Encoding: UTF-8
[11:43:43] [@.Launcher.main/INFO] Java Architecture: x86-64
[11:43:43] [@.Launcher.main/INFO] Java Version: 25.0.4, JetBrains s.r.o.
[11:43:43] [@.Launcher.main/INFO] Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), JetBrains s.r.o.
[11:43:43] [@.Launcher.main/INFO] JVM Max Memory: 1024 MiB
[11:43:43] [@.Launcher.main/INFO] Metaspace: 4.27 MiB
[11:43:43] [@.Launcher.main/INFO] Native Backend: None
[11:43:43] [@.Launcher.main/INFO] XDG Session Type: x11
[11:43:43] [@.Launcher.main/INFO] XDG Current Desktop: KDE
[11:43:43] [@.Launcher.main/INFO] Zlib Compatible: true
[11:43:43] [@.util.platform.SystemInfo.initialize/INFO] System Info:
 - CPU: Intel Core i9-13900HX (24 Cores / 32 Threads)
 - GPU: NVIDIA Device 28E0 (VGA compatible)
 - Memory: 9.58 GiB / 31.14 GiB (30%)
[11:43:43] [@.Launcher.setupJavaFXVMOptions/INFO] HMCL_ANIMATION_FRAME_RATE: 240
[11:43:43] [@.Launcher.start/INFO] JavaFX Version: 25+29
[11:43:43] [@.Launcher.start/INFO] Prism Pipeline: com.sun.prism.es2.ES2Pipeline
[11:43:43] [@.Launcher.start/INFO] Dark Mode: false
[11:43:43] [@.Launcher.start/INFO] Reduced Motion: false
[11:43:43] [@.Launcher.start/INFO] Screens:
 - Screen 1: 2559x1599 @ 1.5x 127dpi in 16" (0, 0, 1706, 1066)
[10:57:14] [@.Launcher.main/INFO] Operating System: Windows 11 26H2 10.0.26300.8935
[10:57:14] [@.Launcher.main/INFO] Processor Identifier: Intel64 Family 6 Model 183 Stepping 1, GenuineIntel
[10:57:14] [@.Launcher.main/INFO] System Architecture: x86-64
[10:57:14] [@.Launcher.main/INFO] Native Encoding: GB18030
[10:57:14] [@.Launcher.main/INFO] JNU Encoding: GBK
[10:57:14] [@.Launcher.main/INFO] Code Page: 936
[10:57:14] [@.Launcher.main/INFO] Java Architecture: x86-64
[10:57:14] [@.Launcher.main/INFO] Java Version: 25.0.3, JetBrains s.r.o.
[10:57:14] [@.Launcher.main/INFO] Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), JetBrains s.r.o.
[10:57:14] [@.Launcher.main/INFO] JVM Max Memory: 1024 MiB
[10:57:14] [@.Launcher.main/INFO] Metaspace: 5.07 MiB
[10:57:14] [@.Launcher.main/INFO] Native Backend: JNA
[10:57:14] [@.Launcher.main/INFO] Zlib Compatible: true
[10:57:14] [@.util.platform.SystemInfo.initialize/INFO] System Info:
 - CPU: Intel Core i9-13900HX (24 Cores / 32 Threads)
 - GPU 1: GameViewer Graphics
 - GPU 2: MuMu Graphics
 - GPU 3: NVIDIA GeForce RTX 4060 Laptop [Discrete]
 - Memory: 20.53 GiB / 31.81 GiB (64%)
[10:57:14] [@.Launcher.setupJavaFXVMOptions/INFO] HMCL_ANIMATION_FRAME_RATE: 240
[10:57:15] [@.Launcher.start/INFO] JavaFX Version: 25+29
[10:57:15] [@.Launcher.start/INFO] Prism Pipeline: com.sun.prism.d3d.D3DPipeline
[10:57:15] [@.Launcher.start/INFO] Dark Mode: false
[10:57:15] [@.Launcher.start/INFO] Reduced Motion: false
[10:57:15] [@.Launcher.start/INFO] Screens:
 - Screen 1: 2561x1601 @ 1.5x 126dpi in 16" (0, 0, 1707, 1067)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants