Repository navigation
Document the folder permission socket events (GRYT-1349) - #127
Merged
Merged
Conversation
server#207 (GRYT-1306) gave folders a permission scope and added server:folders:scope:get, server:folders:scope:set and server:channels:scope:follow, plus client#638 made channels follow a folder by default. None of it was on the socket reference, which listed only the per-channel scope events. Adds the three events, the server:folders:scope reply, and a short paragraph on how a channel keeps its scope when it leaves a folder or the folder is deleted. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…RYT-1349) Vikunja's task description for this one flagged it alongside the folder scope events: a member without manage_channels never sees a channel's row if they can't read it, or a folder left with none of its channels showing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the folder permission socket events that server#207 (GRYT-1306) shipped, now that client#638 makes channels follow a folder by default.
Task: https://tasks.sivert.io/tasks/1406
Events documented
server:channels:scope:follow— drops a channel's own scope, back to following its folderserver:folders:scope:get,server:folders:scope:set— read and set a folder's scope, same shape as the per-channel pairserver:folders:scope— the reply, withchannelCountserver:channels:scopereply: it now carriesfollowsFolderand the folder's id/nameserver:sidebar: it drops a channel the caller can't see and a folder left with none of its channels showing, unless the caller holdsmanage_channelsAll need
manage_channels, same as the channel-scope events next to them.Inheritance
Added a short paragraph above the Administration table: a channel in a folder follows the folder's scope while it has none of its own, setting one (Everyone included) sticks, and pulling a channel out of a folder or deleting the folder leaves it holding whatever scope it was reading rather than reverting to Everyone. Checked this against
resolveChannelScopes,keepScopesOfChannelsLeavingFoldersand where it's called fromupsertServerSidebarItemanddeleteServerSidebarIteminpackages/server/src/db/sqlite/channels.ts.Other pages
No owner-facing page documents per-channel or per-folder permission scopes at all yet —
use/roles.mdxonly covers roles and rank. Nothing to update there for this PR; that gap is bigger than this task.Checked
yarn test:comment-lengthyarn test:webhook-specyarn build🤖 Generated with Claude Code