Repository navigation
Document the guest merge on join and chat:merge_user - #116
Merged
Merged
Conversation
server:verify takes a link, and server:joined says what came of it in identityClaim. chat:merge_user tells clients a guest's id became an account's. account_already_member was listed as a join refusal. It was never sent on server:error, and the server doesn't have it any more. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GRYT-1225. This goes with Gryt-chat/server#193 and merges straight after it. The API reference check here reads server main, which won't have
chat:merge_useruntil that PR lands. Until then it fails on one documented event the server doesn't have. The server PR's check fails the other way round. Without this page it finds 147 of 212 socket events documented, which is under the 70% floor. With it, 148.server:verifytakeslink, andserver:joinedsays what came of it inidentityClaim.chat:merge_useris new.account_already_memberis off the list of join refusals. It was never sent onserver:error, and the server doesn't have it any more.🤖 Generated with Claude Code