Asset fixes#909
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses regressions in SystemCenter’s asset create/edit flows caused by asset-shape changes and missing switch-case handling, restoring the ability to post DER assets and correctly display/edit CapacitorBankRelay attributes.
Changes:
- Render CapacitorBankRelay attribute UI when editing meter assets.
- Update TypeScript “new asset” helpers to reflect updated asset shapes (e.g., Breaker AirGapResistor, Transformer tertiary fields).
- Fix OpenXDA asset posting to (a) read LineSegment values from
Detail, (b) allow posting DER assets, and (c) tolerate optional fields for CapBank/Transformer.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Meter/MeterAsset.tsx | Adds CapacitorBankRelay attribute rendering path in the meter asset UI. |
| Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AssetAttribute/Asset.tsx | Updates “new asset” defaults to match updated asset shapes (Breaker/Transformer). |
| Source/Applications/SystemCenter/Controllers/OpenXDA/Assets/OpenXDAAssetController.cs | Updates server-side asset posting/mapping for Line Detail, DER creation, and optional CapBank/Transformer fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
clackner-gpa
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes problems related to adding Assets to Meter/Substations due to changes in Asset shape not being reflected in Asset-from-JSON helper functions, and oversights in switch statements leading to DERs being unpostable and CapBankRelay attributes not being shown.
Jira Work Item(s)