fix(actions): clone action runs without hardlinks - #3
Merged
Merged
Conversation
`race` failed on main with: TempDir RemoveAll cleanup: unlinkat .../action-work/1/src/.git: directory not empty `executeActionRun` clones the source with `git clone --local`, which hardlinks objects from the repository into the run directory. The deferred `os.RemoveAll(runDir)` then races the git process that may still be writing, and the test's TempDir cleanup loses. `pull_requests.go:535` already clones with `--no-hardlinks`; the action path was missed. Adding the same flag. Reproduces as an intermittent failure — 13 clean runs locally before the fix were possible — so the value here is removing the race, not a red-to-green flip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raceis red onmain:executeActionRunclones withgit clone --local, which hardlinks objects into the run directory. The deferredos.RemoveAll(runDir)races the git process, and the test's TempDir cleanup loses.pull_requests.go:535already uses--no-hardlinks. This applies the same flag to the action path.Full
go test -race ./...green locally, vet and gofmt clean.