Skip to content

Give hot ops shared attributes, and close an interaction with a flagged Meta op - #4753

Merged
TrueDoctor merged 3 commits into
masterfrom
graph-storage-6-transactions
Oct 18, 2026
Merged

TrueDoctor merged 3 commits into
masterfrom
graph-storage-6-transactions

Conversation

@TrueDoctor

Copy link
Copy Markdown
Member

No description provided.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 10 files

Confidence score: 3/5

  • In node-graph/rfcs/document-format.md, retiring Meta can remove the only interaction_end marker after the last write, leaving undo without the boundary it uses to stop. Preserve that marker or ensure the replacement format provides an equivalent boundary.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/rfcs/document-format.md">

<violation number="1" location="node-graph/rfcs/document-format.md:160">
P2: Dropping the `Meta` op at retirement removes the only `interaction_end` marker when the boundary follows the last write. Undo walks the first-parent chain and stops only at an `interaction_end` boundary, so it would merge this interaction into the previous one. State that retirement sets `interaction_end` on the author's last retired delta before dropping the `Meta` op.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread document/graph-storage/src/crdt.rs
Comment thread document/graph-storage/src/session.rs Outdated
Comment thread node-graph/rfcs/document-format.md Outdated
Comment thread node-graph/rfcs/document-format.md Outdated
@TrueDoctor
TrueDoctor added this pull request to the merge queue Oct 18, 2026
Merged via the queue into master with commit b837b39 Oct 18, 2026
11 checks passed
@TrueDoctor
TrueDoctor deleted the graph-storage-6-transactions branch October 18, 2026 18:41

This branch was successfully deployed

1 active deployment
graphite-dev (Preview) — 9115801d Deployed Oct 18, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants