Repository navigation
Switch vector data to the new pool storage throughout the editor and nodes - #4733
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 53 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
3f625e9 to
645bc19
Compare
Performance Benchmark Results
|
Performance Benchmark Results
|
645bc19 to
d994afc
Compare
There was a problem hiding this comment.
2 issues found across 56 files
Confidence score: 3/5
graphic-types/src/lib.rscan split or reopen valid legacy contours when their segments aren’t ordered into same-type runs. Preserve contour continuity during migration.vector_types.rscan produce oversized bounds and thumbnails for curves with distant control handles. Compute bounds from the path contours instead.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="node-graph/libraries/graphic-types/src/lib.rs">
<violation number="1" location="node-graph/libraries/graphic-types/src/lib.rs:139">
P2: This migration assumes the flat legacy segment arrays are already ordered into same-curve-type runs. Reweave starts a new path for an out-of-order segment or verb change, so valid legacy contours can reopen or lose their joins/fill topology; reconstruct paths from connectivity (or preserve the legacy contour boundaries) before converting.</violation>
</file>
<file name="node-graph/libraries/vector-types/src/vector/vector_types.rs">
<violation number="1" location="node-graph/libraries/vector-types/src/vector/vector_types.rs:777">
P2: The direct `Vector` bounding box includes Bézier control handles as rendered geometry, so bounds and thumbnails can be too large for curves with distant handles. Compute these bounds from the path contours, or ensure callers always use the path-aware item/list methods.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Performance Benchmark Results
|
This branch was successfully deployed
1 participant
Wraps existing behavior precisely which results in some expected performance regressions on this PR, which is to be recovered in an upcoming PR.