Skip to content

Add new vector pool storage types, not yet used - #4732

Merged
Keavon merged 8 commits into
masterfrom
vector-pool-storage
Oct 16, 2026
Merged

Keavon merged 8 commits into
masterfrom
vector-pool-storage

Conversation

@Keavon

@Keavon Keavon commented Oct 16, 2026

Copy link
Copy Markdown
Member

No description provided.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 9 files

Confidence score: 5/5

  • contour.rs: subpaths allocates a temporary Vec for every span just to inspect at most four references, adding avoidable overhead for large vectors. Inspect the fixed-index references directly.
  • consts.rs: The rationale for the threshold doesn’t match the 0.5 accuracy passed to Kurbo. Clarify that it controls endpoint coalescing, or derive it from the actual offset precision.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/libraries/vector-types/src/vector/contour.rs">

<violation number="1" location="node-graph/libraries/vector-types/src/vector/contour.rs:109">
P2: `subpaths` heap-allocates a temporary `Vec<u32>` for every span just to inspect at most four references. Large vectors therefore incur one allocation per segment; validate the fixed-index references directly or use stack storage instead.</violation>
</file>

<file name="node-graph/libraries/vector-types/src/vector/algorithms/consts.rs">

<violation number="1" location="node-graph/libraries/vector-types/src/vector/algorithms/consts.rs:11">
P3: This rationale does not match the configured offset accuracy: `offset_bezpath` passes `0.5` to Kurbo, not `1e-6`. Clarify that this is a tighter endpoint-coalescing threshold, or derive it from the actual offset precision.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread node-graph/libraries/vector-types/src/vector/connectivity.rs
Comment thread node-graph/libraries/vector-types/src/vector/addressing.rs
Comment thread node-graph/libraries/vector-types/src/vector/contour.rs
Comment thread node-graph/libraries/vector-types/src/vector/algorithms/consts.rs
@Keavon
Keavon requested a review from TrueDoctor as a code owner October 16, 2026 06:35
@Keavon
Keavon merged commit 46f48a5 into master Oct 16, 2026
11 checks passed
@Keavon
Keavon deleted the vector-pool-storage branch October 16, 2026 06:49

This branch was successfully deployed

1 active deployment
graphite-dev (Preview) — 19c2e4b8 Deployed Oct 16, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant