Skip to content

fix(appengine): pass audience to verify_firebase_token in building-an-app samples - #14770

Merged
iennae merged 1 commit into
GoogleCloudPlatform:mainfrom
macastelaz:fix/verify-firebase-token-audience
Nov 7, 2026
Merged

iennae merged 1 commit into
GoogleCloudPlatform:mainfrom
macastelaz:fix/verify-firebase-token-audience

Conversation

@macastelaz

Copy link
Copy Markdown
Contributor

Description

Pass audience=os.environ.get("GOOGLE_CLOUD_PROJECT") to google.oauth2.id_token.verify_firebase_token() in the App Engine Python 3 building-an-app-3 and building-an-app-4 samples (matching appengine/standard/firebase/firenotes/backend/main.py and the updated google-auth verify_firebase_token guidance).

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

@macastelaz
macastelaz requested review from a team as code owners November 7, 2026 02:56
@product-auto-label product-auto-label Bot added api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples. labels Nov 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request imports the os module and updates the verify_firebase_token function calls in both building-an-app-3 and building-an-app-4 to include the audience parameter, which is retrieved from the GOOGLE_CLOUD_PROJECT environment variable. There are no review comments, and I have no additional feedback to provide.

@iennae
iennae merged commit 548ceb3 into GoogleCloudPlatform:main Nov 7, 2026
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants