Repository navigation
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new sample for creating a BigQuery stored procedure, complete with its implementation, unit tests, and configuration files. The feedback suggests updating the Python test configuration in noxfile_config.py to target only the oldest and newest supported Python versions (3.10 and 3.13) by ignoring intermediate versions. Additionally, it recommends removing the unnecessary environment marker for Python 3.10 in requirements-test.txt and using the === operator for strict version pinning.
| @@ -0,0 +1 @@ | |||
| pytest==9.0.3; python_version >= "3.10" | |||
There was a problem hiding this comment.
Since Python versions below 3.10 are no longer supported, we should not specify environment markers for Python versions older than 3.10. Please remove the ; python_version >= "3.10" marker. Additionally, use the === operator for version pinning in requirements files to prevent automated updates from overwriting specific version numbers.
pytest===9.0.3
References
- Do not specify fallback dependency versions or environment markers for Python versions older than 3.10, as Python versions below 3.10 are no longer supported.
- Use the
===operator inrequirements.txtfor version pinning to prevent automated updates from overwriting specific version numbers required for certain Python runtimes.
23dd9e0 to
c445f53
Compare
…stored procedure Problem: The BigQuery documentation (https://cloud.google.com/bigquery/docs/procedures) needs a standalone, tested Python code sample demonstrating how to create a SQL stored procedure (region tag `bigquery_create_procedure`). Solution: - Add `create_procedure(project_id: str, dataset_id: str) -> None` in `bigquery/stored_procedures/bigquery_create_procedure.py` (Create a reusable multi-statement GoogleSQL stored procedure inside a BigQuery dataset using CREATE OR REPLACE PROCEDURE.) - Add unit tests (`bigquery/stored_procedures/bigquery_create_procedure_test.py`) covering both the success path and API error handling (`GoogleAPICallError`)
c445f53 to
159a10b
Compare
…stored procedure
Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/procedures) needs a standalone, tested Python code sample demonstrating how to create a SQL stored procedure (region tag
bigquery_create_procedure).Solution:
create_procedure(project_id: str, dataset_id: str) -> Noneinbigquery/stored_procedures/bigquery_create_procedure.py(Create a reusable multi-statement GoogleSQL stored procedure inside a BigQuery dataset using CREATE PROCEDURE.)bigquery/stored_procedures/bigquery_create_procedure_test.py) covering both the success path and API error handling (GoogleAPICallError)Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions