Repository navigation
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
5541db0 to
a823efe
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces a new Python sample script and unit tests for creating an IVF vector index on a BigQuery table. It also adds the necessary configuration and dependency files for testing. The feedback suggests updating the noxfile_config.py to remove Python 3.10 from the ignored versions list, ensuring that the oldest supported Python version is properly tested in accordance with repository guidelines.
|
|
||
| TEST_CONFIG_OVERRIDE = { | ||
| # You can opt out from the test for specific Python versions. | ||
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], |
There was a problem hiding this comment.
According to the repository's general rules, we should only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions. Since requirements-test.txt specifies python_version >= "3.10", Python 3.10 is the oldest supported version and should be tested. Please remove "3.10" from ignored_versions.
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], | |
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.11"], |
References
- Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.
a823efe to
e6cf67c
Compare
…IVF vector index on embedding column Problem: The BigQuery documentation (https://cloud.google.com/bigquery/docs/vector-index) needs a standalone, tested Python code sample demonstrating how to create an IVF vector index on embedding column (region tag `bigquery_create_vector_index`). Solution: - Add `create_vector_index(project_id: str, dataset_id: str, table_id: str) -> None` in `bigquery/vector_search/bigquery_create_vector_index.py` (Create an inverted file (IVF) vector index on an array embedding column in BigQuery using CREATE OR REPLACE VECTOR INDEX.) - Add unit tests (`bigquery/vector_search/bigquery_create_vector_index_test.py`) covering both the success path and API error handling (`GoogleAPICallError`)
e6cf67c to
01efd05
Compare
…IVF vector index on embedding column
Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/vector-index) needs a standalone, tested Python code sample demonstrating how to create an IVF vector index on embedding column (region tag
bigquery_create_vector_index).Solution:
create_vector_index(project_id: str, dataset_id: str, table_id: str) -> Noneinbigquery/vector_search/bigquery_create_vector_index.py(Create an inverted file (IVF) vector index on an array embedding column in BigQuery using CREATE VECTOR INDEX.)bigquery/vector_search/bigquery_create_vector_index_test.py) covering both the success path and API error handling (GoogleAPICallError)Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions