Repository navigation
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Python sample and corresponding unit tests for configuring and querying a temporary BigQuery external table backed by Cloud Bigtable. Feedback on the changes suggests updating the noxfile_config.py to remove Python 3.10 from the ignored_versions list, ensuring that the oldest supported Python version is properly tested in accordance with repository guidelines.
|
|
||
| TEST_CONFIG_OVERRIDE = { | ||
| # You can opt out from the test for specific Python versions. | ||
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], |
There was a problem hiding this comment.
According to the repository's general rules, we should only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions. Since requirements-test.txt specifies python_version >= "3.10", Python 3.10 is the oldest supported version and should be tested. Therefore, "3.10" should be removed from ignored_versions so that it is included in the test runs, while intermediate versions like "3.11" remain ignored.
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], | |
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.11"], |
References
- Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.
ffd0e91 to
b348934
Compare
…Cloud Bigtable data as an external table Problem: The BigQuery documentation (https://cloud.google.com/bigquery/docs/external-data-bigtable) needs a standalone, tested Python code sample demonstrating how to query Cloud Bigtable data as an external table (region tag `bigquery_query_external_bigtable`). Solution: - Add `query_external_bigtable(project_id: str, bigtable_instance_id: str, bigtable_table_id: str) -> None` in `bigquery/biglake/bigquery_query_external_bigtable.py` (Configure a temporary Cloud Bigtable external table mapping column families and qualifiers and query it from BigQuery.) - Add unit tests (`bigquery/biglake/bigquery_query_external_bigtable_test.py`) covering both the success path and API error handling (`GoogleAPICallError`)
b348934 to
27459f3
Compare
…Cloud Bigtable data as an external table
Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/external-data-bigtable) needs a standalone, tested Python code sample demonstrating how to query Cloud Bigtable data as an external table (region tag
bigquery_query_external_bigtable).Solution:
query_external_bigtable(project_id: str, bigtable_instance_id: str, bigtable_table_id: str) -> Noneinbigquery/biglake/bigquery_query_external_bigtable.py(Configure a temporary Cloud Bigtable external table mapping column families and qualifiers and query it from BigQuery.)bigquery/biglake/bigquery_query_external_bigtable_test.py) covering both the success path and API error handling (GoogleAPICallError)Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions