Repository navigation
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Python sample and associated unit tests for running federated queries from BigQuery to Cloud Spanner using EXTERNAL_QUERY. The feedback suggests updating the noxfile_config.py to ignore intermediate Python versions (3.11 and 3.12) so that only the oldest (3.10) and newest (3.13) supported versions are tested, aligning with the repository's testing guidelines.
|
|
||
| TEST_CONFIG_OVERRIDE = { | ||
| # You can opt out from the test for specific Python versions. | ||
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], |
There was a problem hiding this comment.
According to the repository's testing guidelines, we should only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions. Since the oldest supported version is Python 3.10 (as indicated by requirements-test.txt), we should test 3.10 and 3.13, while ignoring intermediate versions like 3.11 and 3.12.
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], | |
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.11", "3.12"], |
References
- Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.
838e511 to
0873908
Compare
…federated query against Cloud Spanner Problem: The BigQuery documentation (https://cloud.google.com/bigquery/docs/spanner-federated-queries) needs a standalone, tested Python code sample demonstrating how to run a federated query against Cloud Spanner (region tag `bigquery_federated_query_spanner`). Solution: - Add `federated_query_spanner(project_id: str, connection_id: str) -> None` in `bigquery/federated_queries/bigquery_federated_query_spanner.py` (Query a Cloud Spanner database table in real time from BigQuery using EXTERNAL_QUERY.) - Add unit tests (`bigquery/federated_queries/bigquery_federated_query_spanner_test.py`) covering both the success path and API error handling (`GoogleAPICallError`)
0873908 to
3ee3dbc
Compare
…federated query against Cloud Spanner
Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/spanner-federated-queries) needs a standalone, tested Python code sample demonstrating how to run a federated query against Cloud Spanner (region tag
bigquery_federated_query_spanner).Solution:
federated_query_spanner(project_id: str, connection_id: str) -> Noneinbigquery/federated_queries/bigquery_federated_query_spanner.py(Query a Cloud Spanner database table in real time from BigQuery using EXTERNAL_QUERY.)bigquery/federated_queries/bigquery_federated_query_spanner_test.py) covering both the success path and API error handling (GoogleAPICallError)Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions