Repository navigation
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Python script and unit tests to update a BigQuery search index by dropping a column using the ALTER SEARCH INDEX statement. It also includes the necessary configuration and requirements files. The review feedback suggests correcting the ignored Python versions in noxfile_config.py to ensure that only the oldest and newest supported Python releases are tested, aligning with the testing guidelines.
|
|
||
| TEST_CONFIG_OVERRIDE = { | ||
| # You can opt out from the test for specific Python versions. | ||
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], |
There was a problem hiding this comment.
According to the testing guidelines, we should only test the oldest and newest supported Python releases in test configurations, ignoring intermediate versions. Since Python 3.10 is the oldest supported version (as indicated by requirements-test.txt), it should not be ignored. Intermediate versions like 3.11 and 3.12 should be ignored instead.
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], | |
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.11", "3.12"], |
References
- Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.
497ee78 to
f14a90f
Compare
…umns in an existing search index Problem: The BigQuery documentation (https://cloud.google.com/bigquery/docs/search-index) needs a standalone, tested Python code sample demonstrating how to update columns in an existing search index (region tag `bigquery_update_search_index`). Solution: - Add `update_search_index(project_id: str, dataset_id: str, table_id: str) -> None` in `bigquery/search/bigquery_update_search_index.py` (Modify an existing BigQuery search index using ALTER SEARCH INDEX ... ADD COLUMNS / DROP COLUMNS.) - Add unit tests (`bigquery/search/bigquery_update_search_index_test.py`) covering both the success path and API error handling (`GoogleAPICallError`)
f14a90f to
dbca00d
Compare
…umns in an existing search index
Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/search-index) needs a standalone, tested Python code sample demonstrating how to update columns in an existing search index (region tag
bigquery_update_search_index).Solution:
update_search_index(project_id: str, dataset_id: str, table_id: str) -> Noneinbigquery/search/bigquery_update_search_index.py(Modify an existing BigQuery search index using ALTER SEARCH INDEX ... ADD COLUMNS / DROP COLUMNS.)bigquery/search/bigquery_update_search_index_test.py) covering both the success path and API error handling (GoogleAPICallError)Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions