Skip to content

feat(bigquery): add bigquery_federated_view_schema_spanner sample to … - #14743

Open
iennae wants to merge 1 commit into
mainfrom
feat/bq-federated-view-schema-spanner
Open

iennae wants to merge 1 commit into
mainfrom
feat/bq-federated-view-schema-spanner

Conversation

@iennae

@iennae iennae commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

…inspect Cloud Spanner table schema via federated query

Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/spanner-federated-queries) needs a standalone, tested Python code sample demonstrating how to inspect Cloud Spanner table schema via federated query (region tag bigquery_federated_view_schema_spanner).

Solution:

  • Add federated_view_schema_spanner(project_id: str, connection_id: str) -> None in bigquery/federated_queries/bigquery_federated_view_schema_spanner.py (Query information_schema.columns in a Cloud Spanner database from BigQuery using EXTERNAL_QUERY.)
  • Add unit tests (bigquery/federated_queries/bigquery_federated_view_schema_spanner_test.py) covering both the success path and API error handling (GoogleAPICallError)

Description

Fixes #

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

@iennae
iennae requested review from a team and chalmerlowe as code owners November 2, 2026 23:24
@snippet-bot

snippet-bot Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples. labels Nov 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Python sample, bigquery_federated_view_schema_spanner.py, along with its corresponding unit tests and configuration files, to demonstrate how to view a Cloud Spanner table schema from BigQuery using EXTERNAL_QUERY. The feedback recommends updating the ignored_versions list in noxfile_config.py to ensure that only the oldest (3.10) and newest (3.13) supported Python versions are tested, ignoring intermediate versions like 3.11 and 3.12.


TEST_CONFIG_OVERRIDE = {
# You can opt out from the test for specific Python versions.
"ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the repository rules, we should only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions. Since Python 3.10 is the oldest supported version (as indicated by python_version >= '3.10' in requirements-test.txt) and Python 3.13 is the newest, we should test 3.10 and 3.13, while ignoring intermediate versions (3.11 and 3.12). Please update ignored_versions to include 3.11 and 3.12 instead of 3.10.

Suggested change
"ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"],
"ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.11", "3.12"],
References
  1. Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.

@iennae
iennae force-pushed the feat/bq-federated-view-schema-spanner branch 2 times, most recently from 27b4c38 to 7853f1a Compare November 3, 2026 02:44
…inspect Cloud Spanner table schema via federated query

Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/spanner-federated-queries)
needs a standalone, tested Python code sample demonstrating how to
inspect Cloud Spanner table schema via federated query (region tag `bigquery_federated_view_schema_spanner`).

Solution:
- Add `federated_view_schema_spanner(project_id: str, connection_id: str) -> None` in `bigquery/federated_queries/bigquery_federated_view_schema_spanner.py`
  (Query information_schema.columns in a Cloud Spanner database from BigQuery using EXTERNAL_QUERY.)
- Add unit tests (`bigquery/federated_queries/bigquery_federated_view_schema_spanner_test.py`) covering both the success
  path and API error handling (`GoogleAPICallError`)
@iennae
iennae force-pushed the feat/bq-federated-view-schema-spanner branch from 7853f1a to d0a4e80 Compare November 3, 2026 23:32

@XrossFox XrossFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants