Repository navigation
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Python sample, bigquery_federated_view_schema_spanner.py, along with its corresponding unit tests and configuration files, to demonstrate how to view a Cloud Spanner table schema from BigQuery using EXTERNAL_QUERY. The feedback recommends updating the ignored_versions list in noxfile_config.py to ensure that only the oldest (3.10) and newest (3.13) supported Python versions are tested, ignoring intermediate versions like 3.11 and 3.12.
|
|
||
| TEST_CONFIG_OVERRIDE = { | ||
| # You can opt out from the test for specific Python versions. | ||
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], |
There was a problem hiding this comment.
According to the repository rules, we should only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions. Since Python 3.10 is the oldest supported version (as indicated by python_version >= '3.10' in requirements-test.txt) and Python 3.13 is the newest, we should test 3.10 and 3.13, while ignoring intermediate versions (3.11 and 3.12). Please update ignored_versions to include 3.11 and 3.12 instead of 3.10.
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], | |
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.11", "3.12"], |
References
- Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.
27b4c38 to
7853f1a
Compare
…inspect Cloud Spanner table schema via federated query Problem: The BigQuery documentation (https://cloud.google.com/bigquery/docs/spanner-federated-queries) needs a standalone, tested Python code sample demonstrating how to inspect Cloud Spanner table schema via federated query (region tag `bigquery_federated_view_schema_spanner`). Solution: - Add `federated_view_schema_spanner(project_id: str, connection_id: str) -> None` in `bigquery/federated_queries/bigquery_federated_view_schema_spanner.py` (Query information_schema.columns in a Cloud Spanner database from BigQuery using EXTERNAL_QUERY.) - Add unit tests (`bigquery/federated_queries/bigquery_federated_view_schema_spanner_test.py`) covering both the success path and API error handling (`GoogleAPICallError`)
7853f1a to
d0a4e80
Compare
…inspect Cloud Spanner table schema via federated query
Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/spanner-federated-queries) needs a standalone, tested Python code sample demonstrating how to inspect Cloud Spanner table schema via federated query (region tag
bigquery_federated_view_schema_spanner).Solution:
federated_view_schema_spanner(project_id: str, connection_id: str) -> Noneinbigquery/federated_queries/bigquery_federated_view_schema_spanner.py(Query information_schema.columns in a Cloud Spanner database from BigQuery using EXTERNAL_QUERY.)bigquery/federated_queries/bigquery_federated_view_schema_spanner_test.py) covering both the success path and API error handling (GoogleAPICallError)Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions