Repository navigation
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new sample script and tests for reading projected columns from a BigLake table using the BigQuery Storage Read API. The feedback suggests updating the test configuration in noxfile_config.py to ensure only the oldest (3.10) and newest (3.13) supported Python versions are tested, ignoring intermediate versions like 3.11 and 3.12.
|
|
||
| TEST_CONFIG_OVERRIDE = { | ||
| # You can opt out from the test for specific Python versions. | ||
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], |
There was a problem hiding this comment.
According to the repository's testing rules, you should only test the oldest and newest supported Python releases in test configurations, ignoring intermediate versions. Since Python 3.10 is the oldest supported version (as indicated by requirements-test.txt) and Python 3.13 is the newest, you should test 3.10 and 3.13, and ignore intermediate versions like 3.11 and 3.12.
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], | |
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.11", "3.12"], |
References
- Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.
0d85b5f to
66dc90a
Compare
…ead a BigLake Cloud Storage table via BigQuery Storage Read API Problem: The BigQuery documentation (https://cloud.google.com/bigquery/docs/query-cloud-storage-using-biglake) needs a standalone, tested Python code sample demonstrating how to read a BigLake Cloud Storage table via BigQuery Storage Read API (region tag `bigquery_read_biglake_gcs_storage_api`). Solution: - Add `read_biglake_gcs_storage_api(project_id: str, dataset_id: str, table_id: str) -> None` in `bigquery/biglake/bigquery_read_biglake_gcs_storage_api.py` (Stream rows from a BigLake table backed by Cloud Storage using the BigQuery Storage Read API client.) - Add unit tests (`bigquery/biglake/bigquery_read_biglake_gcs_storage_api_test.py`) covering both the success path and API error handling (`GoogleAPICallError`)
66dc90a to
2a845cf
Compare
XrossFox
left a comment
There was a problem hiding this comment.
There is a dependency on the requirements file that doesnt seem to be available on Pypi.
…ead a BigLake Cloud Storage table via BigQuery Storage Read API
Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/query-cloud-storage-using-biglake) needs a standalone, tested Python code sample demonstrating how to read a BigLake Cloud Storage table via BigQuery Storage Read API (region tag
bigquery_read_biglake_gcs_storage_api).Solution:
read_biglake_gcs_storage_api(project_id: str, dataset_id: str, table_id: str) -> Noneinbigquery/biglake/bigquery_read_biglake_gcs_storage_api.py(Stream rows from a BigLake table backed by Cloud Storage using the BigQuery Storage Read API client.)bigquery/biglake/bigquery_read_biglake_gcs_storage_api_test.py) covering both the success path and API error handling (GoogleAPICallError)Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions