Repository navigation
feat(bigquery): add bigquery_query_iceberg_table sample to refresh an… - #14718
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Python sample and associated tests for refreshing and querying Apache Iceberg external tables in BigQuery. The feedback suggests improving the sample's reusability by replacing the specific column selection in the SQL query with a generic SELECT * and a LIMIT clause. Additionally, it recommends updating the test configuration in noxfile_config.py to only test the oldest and newest supported Python versions (3.10 and 3.13) in accordance with testing guidelines.
XrossFox
left a comment
There was a problem hiding this comment.
LGTM, some dependencies are outdated.
43ac8a3 to
e719bde
Compare
…d query an Apache Iceberg BigLake table Problem: The BigQuery documentation (https://cloud.google.com/bigquery/docs/query-iceberg-data) needs a standalone, tested Python code sample demonstrating how to refresh and query an Apache Iceberg BigLake table (region tag `bigquery_query_iceberg_table`). Solution: - Add `query_iceberg_table(project_id: str, dataset_id: str, table_id: str, connection_id: str, metadata_uri: str) -> None` in `bigquery/biglake/bigquery_query_iceberg_table.py` (Update an Apache Iceberg external table definition to point to the latest metadata snapshot on Cloud Storage and query its rows.) - Add unit tests (`bigquery/biglake/bigquery_query_iceberg_table_test.py`) covering both the success path and API error handling (`GoogleAPICallError`)
e719bde to
2578a5c
Compare
…d query an Apache Iceberg BigLake table
Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/query-iceberg-data) needs a standalone, tested Python code sample demonstrating how to refresh and query an Apache Iceberg BigLake table (region tag
bigquery_query_iceberg_table).Solution:
query_iceberg_table(project_id: str, dataset_id: str, table_id: str, connection_id: str, metadata_uri: str) -> Noneinbigquery/biglake/bigquery_query_iceberg_table.py(Update an Apache Iceberg external table definition to point to the latest metadata snapshot on Cloud Storage and query its rows.)bigquery/biglake/bigquery_query_iceberg_table_test.py) covering both the success path and API error handling (GoogleAPICallError)Checklist
Testing
Compliance & Style
Post-Approval Actions