Repository navigation
feat(bigquery): add dataplex_delete_data_profile_scan sample to delet… - #14716
Merged
Merged
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
Bot
added
api: bigquery
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new Python script to delete a Dataplex data profile scan resource, along with its corresponding unit tests and configuration files. The feedback suggests updating the noxfile_config.py file to ignore intermediate Python versions (3.11 and 3.12) and only test the oldest (3.10) and newest (3.13) supported releases, in accordance with repository guidelines.
iennae
force-pushed
the
feat/bq-dataplex-delete-data-profile-scan
branch
3 times, most recently
from
November 2, 2026 23:33
c2732d1 to
916d585
Compare
…e a Dataplex data profile scan Problem: The Dataplex documentation (https://cloud.google.com/dataplex/docs/use-data-profiling#delete-scans) needs a standalone, tested Python code sample demonstrating how to delete a Dataplex data profile scan (region tag `dataplex_delete_data_profile_scan`). Solution: - Add `delete_data_profile_scan(project_id: str, location: str, data_scan_id: str) -> None` in `bigquery/data_profile_scan/dataplex_delete_data_profile_scan.py` (Delete a Dataplex data profile scan resource using DataScanServiceClient.delete_data_scan and await completion.) - Add unit tests (`bigquery/data_profile_scan/dataplex_delete_data_profile_scan_test.py`) covering both the success path and API error handling (`GoogleAPICallError`)
iennae
force-pushed
the
feat/bq-dataplex-delete-data-profile-scan
branch
from
November 3, 2026 02:44
916d585 to
ce061f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e a Dataplex data profile scan
Problem:
The Dataplex documentation (https://cloud.google.com/dataplex/docs/use-data-profiling#delete-scans) needs a standalone, tested Python code sample demonstrating how to delete a Dataplex data profile scan (region tag
dataplex_delete_data_profile_scan).Solution:
delete_data_profile_scan(project_id: str, location: str, data_scan_id: str) -> Noneinbigquery/data_profile_scan/dataplex_delete_data_profile_scan.py(Delete a Dataplex data profile scan resource using DataScanServiceClient.delete_data_scan and await completion.)bigquery/data_profile_scan/dataplex_delete_data_profile_scan_test.py) covering both the success path and API error handling (GoogleAPICallError)Checklist
Testing
Compliance & Style
Post-Approval Actions