Repository navigation
feat(bigquery): add bigquery_create_search_index sample to create a s… - #14714
Merged
Merged
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
Bot
added
api: bigquery
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a script to create a BigQuery search index across all columns of a table, along with corresponding unit tests and configuration files. The feedback highlights two main improvements: first, removing 'IF NOT EXISTS' from the SQL query in bigquery_create_search_index.py to prevent the AlreadyExists exception handling from becoming dead code; second, updating the ignored Python versions in noxfile_config.py to align with the policy of testing only the oldest and newest supported releases.
iennae
force-pushed
the
feat/bq-create-search-index
branch
from
November 2, 2026 21:43
1687fd4 to
5abcfd2
Compare
iennae
force-pushed
the
feat/bq-create-search-index
branch
from
November 2, 2026 22:35
5abcfd2 to
f102df8
Compare
…earch index on a table Problem: The BigQuery documentation (https://cloud.google.com/bigquery/docs/search-index) needs a standalone, tested Python code sample demonstrating how to create a search index on a table (region tag `bigquery_create_search_index`). Solution: - Add `create_search_index(project_id: str, dataset_id: str, table_id: str) -> None` in `bigquery/search/bigquery_create_search_index.py` (Create a BigQuery search index on ALL COLUMNS or selected columns of a table using CREATE SEARCH INDEX.) - Add unit tests (`bigquery/search/bigquery_create_search_index_test.py`) covering both the success path and API error handling (`GoogleAPICallError`)
iennae
force-pushed
the
feat/bq-create-search-index
branch
from
November 2, 2026 23:33
f102df8 to
c317432
Compare
iennae
added a commit
that referenced
this pull request
Nov 3, 2026
… up test mocks Problem: Following review feedback across the BigQuery sample PRs (#14714, #14715, #14717): - `bigquery_create_search_index.py` should use `CREATE SEARCH INDEX IF NOT EXISTS` and handle `exceptions.NotFound` when the parent table or dataset is missing. - `bigquery_drop_vector_index.py` `NotFound` error message should reflect that `DROP VECTOR INDEX IF EXISTS` raises `NotFound` when the parent table or dataset is missing. - Unit tests in `bigquery_create_search_index_test.py`, `bigquery_drop_vector_index_test.py`, and `bigquery_query_manifest_external_table_test.py` defined unused mock attributes (`mock_row` on DDL statements and `mock_job.statement_type` on SELECT queries). Solution: - Restore `CREATE SEARCH INDEX IF NOT EXISTS` and catch `exceptions.NotFound` in `bigquery/search/bigquery_create_search_index.py` and its unit test. - Update the `NotFound` error message in `bigquery/vector_search/bigquery_drop_vector_index.py`. - Remove unused `mock_row` and `mock_job.statement_type` setup in the three corresponding unit test files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…earch index on a table
Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/search-index) needs a standalone, tested Python code sample demonstrating how to create a search index on a table (region tag
bigquery_create_search_index).Solution:
create_search_index(project_id: str, dataset_id: str, table_id: str) -> Noneinbigquery/search/bigquery_create_search_index.py(Create a BigQuery search index on ALL COLUMNS or selected columns of a table using CREATE SEARCH INDEX.)bigquery/search/bigquery_create_search_index_test.py) covering both the success path and API error handling (GoogleAPICallError)Checklist
Testing
Compliance & Style
Post-Approval Actions