Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading
datasetsto5.1.0will break the training scriptweather/trainer.py. Indatasetsv5, internal modules likedatasets.arrow_datasetanddatasets.dataset_dicthave been refactored or removed, causing imports likefrom datasets.arrow_dataset import Datasetto fail with anImportError.\n\nTo resolve this, please update the imports inpeople-and-planet-ai/weather-forecasting/serving/weather-model/weather/trainer.py(lines 22-23) to import directly from the public API:\n\npython\nfrom datasets import Dataset, DatasetDict\n