chore(secretmanager): format snippets and update dependencies#14370
Merged
XrossFox merged 5 commits intoJul 14, 2026
Merged
Conversation
- Run black formatter on secretmanager snippet files. - Update protobuf, google-cloud-resource-manager, google-cloud-secret-manager, and google-crc32c. - Remove python version constraint for pytest in requirements-test.txt.
product-auto-label
Bot
added
api: secretmanager
Contributor
Author
|
Tested using nox on python 3.10 and 3.14: 
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request primarily applies code formatting and style updates across several Secret Manager snippet files and tests, alongside updating dependencies in the requirements files. The review feedback highlights critical type-handling issues where version_destroy_ttl is parsed as a string instead of an integer in command-line arguments, a missing help= keyword argument in update_secret_with_delayed_destroy.py that would cause a runtime error, and a type annotation mismatch in snippets_test.py.
Kef131
reviewed
Jul 1, 2026
Kef131
approved these changes
Jul 1, 2026
amcolin
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/527484406
Checklist
Testing
Compliance & Style
Post-Approval Actions