Skip to content

chore(dataproc): update package dependencies in dataproc - #4426

Draft
angelcaamal wants to merge 3 commits into
mainfrom
chore/update-dataproc-samples-package
Draft

chore(dataproc): update package dependencies in dataproc#4426
angelcaamal wants to merge 3 commits into
mainfrom
chore/update-dataproc-samples-package

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes Internal: b/553468643

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: dataproc Issues related to the Managed Service for Apache Spark API. samples Issues that are directly related to samples. labels Aug 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies in dataproc/package.json, including @google-cloud/dataproc, @google-cloud/storage, c8, and chai. The review feedback correctly identifies that upgrading chai to ^6.0.0 will break the tests because Chai v5 and above are ESM-only, whereas this project is configured as CommonJS. It is recommended to revert chai to ^4.5.0 to maintain compatibility.

Comment thread dataproc/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dataproc Issues related to the Managed Service for Apache Spark API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant