chore(video-intelligence): update package dependencies - #4422
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Node.js engine requirement to >=20.0.0 and upgrades several dependencies in video-intelligence/package.json, including @google-cloud/video-intelligence, c8, and chai. Feedback was provided to revert the chai upgrade to ^4.5.0, as upgrading to v6.0.0 will cause test failures due to ESM-only compatibility issues in a CommonJS project.
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "c8": "^12.0.0", | ||
| "chai": "^6.0.0", |
There was a problem hiding this comment.
Chai v5.0.0 and above (including v6.0.0) are ESM-only. Since this project is configured as CommonJS (it lacks "type": "module" in package.json and uses require in its source files), upgrading to chai v6 will cause tests to fail with ERR_REQUIRE_ESM when trying to require chai. It is recommended to keep chai at ^4.5.0 unless the project is migrated to ESM.
| "chai": "^6.0.0", | |
| "chai": "^4.5.0", |
Description
Fixes Internal: b/553467107
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.