Assorted cleanups of GKE resources - #18986
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit baf235b: Diff reportYour PR generated the following diffs in downstream repositories:
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_pool {
node_config {
host_maintenance_policy {
maintenance_interval = # value needed
}
}
}
}
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccContainerCluster_nodePool_acceleratorNetworkProfile_Lifecycle Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rileykarson VCR tests complete for baf235b! |
baf235b to
722bd9c
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 722bd9c: Diff reportYour PR generated the following diffs in downstream repositories:
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_pool {
node_config {
host_maintenance_policy {
maintenance_interval = # value needed
}
}
}
}
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccContainerCluster_nodePool_acceleratorNetworkProfile_Lifecycle Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rileykarson VCR tests complete for 722bd9c! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c1c9640: Diff reportYour PR generated the following diffs in downstream repositories:
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_pool {
node_config {
host_maintenance_policy {
maintenance_interval = # value needed
}
}
}
}
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccContainerCluster_nodePool_acceleratorNetworkProfile_Lifecycle Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rileykarson VCR tests complete for c1c9640! |
slevenick
left a comment
There was a problem hiding this comment.
Is there a bug for using host_maintenance_policy in GA? Breaking change seems fine if it was never actually creatable
|
The field was documented as beta, doesn't work in the API, and the expander/flattener were properly guarded as beta. Just a bit of schema was wrong, otherwise I'd tombstone instead. Error: |
e58934a
Hygiene pass for GKE (
google_container_clusterandgoogle_container_node_pool):host_maintenance_policyschema and metadata entries innode_config.user_managed_keys_config,tpu_config,host_maintenance_policy,windows_node_config,containerd_config.registry_hosts, and fleet attributes).operationacross cluster and node pool resources.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.