Reduce GKE test runtimes and quota pressure - #18982
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b6e4445: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 48 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rileykarson VCR tests complete for b6e4445! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5d5933b: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rileykarson VCR tests complete for 5d5933b! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2cd7598: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rileykarson VCR tests complete for 2cd7598! |
There was a problem hiding this comment.
In most of the modified configs both google_container_cluster and google_container_node_pool had initial_node_count changed, others had only a google_container_cluster change. That changes some of the tests, which have a mixture of configs, e.g., TestAccContainerNodePool_totalSize has three steps:
testAccContainerNodePool_totalSize cluster 3->1 np 2->2
testAccContainerNodePool_updateTotalSize cluster 3->1 np 2->2
testAccContainerNodePool_basicTotalSize cluster 3->1 np 2->1
This seems to affect TestAccContainerCluster_withNodePoolAutoscaling, TestAccContainerCluster_withNodePoolCIA, TestAccContainerNodePool_autoscaling, and TestAccContainerNodePool_regionalAutoscaling too.
There was a problem hiding this comment.
Good catch, thanks
I'll follow up and force explicit update checks in a separate PR
…er_cluster_sweeper.go Co-authored-by: Chris Hawk <chrishawk+github@gmail.com>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 64bd005: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rileykarson VCR tests complete for 64bd005! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit dabe5a8: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rileykarson VCR tests complete for dabe5a8! |
7a83c2e
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.