Skip to content

redis: move acceptance tests and samples to us-west1 - #18977

Open
SirGitsalot wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
SirGitsalot:move-redis-tests-us-west1
Open

redis: move acceptance tests and samples to us-west1#18977
SirGitsalot wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
SirGitsalot:move-redis-tests-us-west1

Conversation

@SirGitsalot

Copy link
Copy Markdown
Member

Description:
This PR updates the Magic Modules acceptance tests, samples, and sweepers for the redis service to run in us-west.

  • Sweepers:
    • Configured sweeper.url_substitutions in mmv1/products/redis/Instance.yaml and mmv1/products/redis/ClusterAclPolicy.yaml to sweep both us-central1 and us-west1.
    • Added - region: us-west1 to Cluster.yaml sweepers.
  • Samples:
    • Updated all redis samples in mmv1/templates/terraform/samples/services/redis/ to target us-west1 (updating region, location, location_id, and alternative_location_id).
  • Handwritten Tests:
    • Updated handwritten acceptance tests and data source tests in mmv1/third_party/terraform/services/redis/ to target us-west1.

Release Note:

@modular-magician

modular-magician commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 788a281:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 15 files changed, 403 insertions(+), 162 deletions(-)
google-beta provider View Diff 15 files changed, 403 insertions(+), 162 deletions(-)
Open in Cloud Shell View Diff 15 files changed, 51 insertions(+), 46 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
43 1 0 42
Affected Service Packages
  • redis

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 42 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccRedisClusterAclPolicyDatasource
  • TestAccRedisClusterAclPolicy_basic
  • TestAccRedisClusterAclPolicy_withCluster
  • TestAccRedisClusterDatasource
  • TestAccRedisClusterUserCreatedConnections_redisClusterUserAndAutoCreatedConnectionsExample
  • TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample
  • TestAccRedisCluster_automatedBackupConfig
  • TestAccRedisCluster_createClusterWithZoneDistribution
  • TestAccRedisCluster_createUpdateClusterWithNodeType
  • TestAccRedisCluster_createUpdateDeletionProtection
  • TestAccRedisCluster_customerManagedCas
  • TestAccRedisCluster_gcsSource
  • TestAccRedisCluster_managedBackupSource
  • TestAccRedisCluster_persistenceUpdate
  • TestAccRedisCluster_redisClusterAofExample
  • TestAccRedisCluster_redisClusterCmekExample
  • TestAccRedisCluster_redisClusterFlexibleCaExample
  • TestAccRedisCluster_redisClusterHaExample
  • TestAccRedisCluster_redisClusterHaSingleZoneExample
  • TestAccRedisCluster_redisClusterHaWithLabelsExample
  • TestAccRedisCluster_redisClusterHaWithLabelsUpdate
  • TestAccRedisCluster_redisClusterRdbExample
  • TestAccRedisCluster_redisClusterSecondaryExample
  • TestAccRedisCluster_redisClusterTlsEnabled
  • TestAccRedisCluster_switchoverAndDetachSecondary
  • TestAccRedisCluster_updateClusterEndpoints
  • TestAccRedisCluster_updateRedisConfigs
  • TestAccRedisCluster_updateReplicaCount
  • TestAccRedisCluster_updateShardCount
  • TestAccRedisCluster_withAclPolicy
  • TestAccRedisInstanceDatasource_basic
  • TestAccRedisInstance_deletionprotection
  • TestAccRedisInstance_downgradeRedisVersion
  • TestAccRedisInstance_redisInstanceAuthEnabled
  • TestAccRedisInstance_redisInstanceBasicExample
  • TestAccRedisInstance_redisInstanceFullExample
  • TestAccRedisInstance_redisInstanceFullWithPersistenceConfigExample
  • TestAccRedisInstance_redisInstanceMrrExample
  • TestAccRedisInstance_redisInstancePrivateServiceTestExample
  • TestAccRedisInstance_update
  • TestAccRedisInstance_updateReadReplicasMode
  • TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccRedisClusterAclPolicyDatasource
✅ Log TestAccRedisClusterAclPolicy_basic
✅ Log TestAccRedisClusterAclPolicy_withCluster
✅ Log TestAccRedisClusterDatasource
✅ Log TestAccRedisClusterUserCreatedConnections_redisClusterUserAndAutoCreatedConnectionsExample
✅ Log TestAccRedisCluster_automatedBackupConfig
✅ Log TestAccRedisCluster_createClusterWithZoneDistribution
✅ Log TestAccRedisCluster_createUpdateClusterWithNodeType
✅ Log TestAccRedisCluster_createUpdateDeletionProtection
✅ Log TestAccRedisCluster_customerManagedCas
✅ Log TestAccRedisCluster_gcsSource
✅ Log TestAccRedisCluster_managedBackupSource
✅ Log TestAccRedisCluster_persistenceUpdate
✅ Log TestAccRedisCluster_redisClusterAofExample
✅ Log TestAccRedisCluster_redisClusterCmekExample
✅ Log TestAccRedisCluster_redisClusterFlexibleCaExample
✅ Log TestAccRedisCluster_redisClusterHaExample
✅ Log TestAccRedisCluster_redisClusterHaSingleZoneExample
✅ Log TestAccRedisCluster_redisClusterHaWithLabelsExample
✅ Log TestAccRedisCluster_redisClusterHaWithLabelsUpdate
✅ Log TestAccRedisCluster_redisClusterRdbExample
✅ Log TestAccRedisCluster_redisClusterSecondaryExample
✅ Log TestAccRedisCluster_redisClusterTlsEnabled
✅ Log TestAccRedisCluster_switchoverAndDetachSecondary
✅ Log TestAccRedisCluster_updateRedisConfigs
✅ Log TestAccRedisCluster_updateReplicaCount
✅ Log TestAccRedisCluster_updateShardCount
✅ Log TestAccRedisCluster_withAclPolicy
✅ Log TestAccRedisInstanceDatasource_basic
✅ Log TestAccRedisInstance_deletionprotection
✅ Log TestAccRedisInstance_downgradeRedisVersion
✅ Log TestAccRedisInstance_redisInstanceAuthEnabled
✅ Log TestAccRedisInstance_redisInstanceBasicExample
✅ Log TestAccRedisInstance_redisInstanceFullExample
✅ Log TestAccRedisInstance_redisInstanceFullWithPersistenceConfigExample
✅ Log TestAccRedisInstance_redisInstanceMrrExample
✅ Log TestAccRedisInstance_redisInstancePrivateServiceTestExample
✅ Log TestAccRedisInstance_update
✅ Log TestAccRedisInstance_updateReadReplicasMode
✅ Log TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp
❌ Error · Log - TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample
❌ Error · Log - TestAccRedisCluster_updateClusterEndpoints

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@SirGitsalot VCR tests complete for 788a281!

Move Magic Modules acceptance tests and samples for redis resources to run in us-west1:
- Configure sweepers in mmv1/products/redis for Instance, ClusterAclPolicy, and Cluster to sweep us-west1 and us-central1
- Update samples in mmv1/templates/terraform/samples/services/redis to use us-west1
- Update handwritten tests in mmv1/third_party/terraform/services/redis to use us-west1
@SirGitsalot
SirGitsalot force-pushed the move-redis-tests-us-west1 branch from 788a281 to b79692f Compare September 12, 2026 00:51
@modular-magician

modular-magician commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b79692f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 15 files changed, 423 insertions(+), 182 deletions(-)
google-beta provider View Diff 15 files changed, 423 insertions(+), 182 deletions(-)
Open in Cloud Shell View Diff 15 files changed, 61 insertions(+), 56 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
43 41 0 2
Affected Service Packages
  • redis

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample
  • TestAccRedisCluster_updateClusterEndpoints

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample
✅ Log TestAccRedisCluster_updateClusterEndpoints

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@SirGitsalot VCR tests complete for b79692f!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants