Skip to content

dialogflow: add tool_call_info to google_dialogflow_generator - #18974

Open
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-558780404
Open

dialogflow: add tool_call_info to google_dialogflow_generator#18974
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-558780404

Conversation

@slevenick

Copy link
Copy Markdown
Contributor

Added field coverage for summarizationContext.fewShotExamples.output.toolCallInfo on google_dialogflow_generator (dialogflow:v2:Generator).

reference: b/558780404

dialogflow: added `summarization_context.few_shot_examples.output.tool_call_info` field to `google_dialogflow_generator`

@modular-magician

modular-magician commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3a7630b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 378 insertions(+)
google-beta provider View Diff 4 files changed, 378 insertions(+)
terraform-google-conversion View Diff 1 file changed, 146 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
22 21 0 1
Affected Service Packages
  • dialogflow

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDialogflowGenerator_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDialogflowGenerator_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for 3a7630b!

@slevenick

Copy link
Copy Markdown
Contributor Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

- name: toolCall
type: NestedObject
description: |
Optional. Request for a tool call.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the authoritative source is, but the service proto says that tool_call and tool_call_result are required (while the parent tool_call_info is optional as are the child fields)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants