Add triage subagent - #18972
Add triage subagent#18972roaks3 wants to merge 2 commits into
Conversation
| #### Recreating the Defect with a Test (RED Check) | ||
| Recreate the reported defect on the unfixed baseline using either a new test or a modified existing test based on `bug-triager`'s analysis: | ||
|
|
||
| * **Option A: Add a New Acceptance/Regression Test (Preferred for distinct scenarios or missing coverage)**: |
There was a problem hiding this comment.
Here's the test piece we talked about. I think I'd propose maybe changing this to be more like "prefer making a small change to an existing test, and if that can't be done, then just be sure to remove the test before committing". Otherwise it seems to be a bit too aggressive in spinning up new low-value tests, and we at least have some capacity for improving tests / preventing regressions.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 61669fa: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
| custom_agent: | ||
| system_prompt_sections: | ||
| - title: "Role & Persona" | ||
| content: "You are a Staff Software Engineer specializing in bug triage, root cause analysis, and context gathering for Google Cloud Terraform providers in Magic Modules." |
There was a problem hiding this comment.
Noting that the "You are a " kind of prompting may be obsolete, I'm not sure there is evidence it matters for newer models. Probably will sweep this type of wording across the repo eventually.
There was a problem hiding this comment.
K, I'm guessing Jetski copied this. I'll leave it for the moment since I think we will merge soon.
Co-authored-by: Ryan Oaks <roaks3@gmail.com>
| - **New Test**: Specify the proposed sample template (`.tf.tmpl` under `mmv1/templates/terraform/samples/services/<product>/`) or handwritten test function (`TestAcc<Resource>_<Scenario>`), including required HCL configuration, variables, and sample registration. | ||
| - **Modify Existing Test**: Identify the specific existing test/sample, file path, and exact configuration changes (arguments, field values, or update steps) needed to trigger the defect. |
There was a problem hiding this comment.
| - **New Test**: Specify the proposed sample template (`.tf.tmpl` under `mmv1/templates/terraform/samples/services/<product>/`) or handwritten test function (`TestAcc<Resource>_<Scenario>`), including required HCL configuration, variables, and sample registration. | |
| - **Modify Existing Test**: Identify the specific existing test/sample, file path, and exact configuration changes (arguments, field values, or update steps) needed to trigger the defect. | |
| - **Modify Existing Test (Strongly Preferred)**: Identify the specific existing test/sample, file path, and exact configuration changes (arguments, field values, or update steps) needed to trigger the defect. | |
| - **New Test**: Specify the proposed sample template (`.tf.tmpl` under `mmv1/templates/terraform/samples/services/<product>/`) or handwritten test function (`TestAcc<Resource>_<Scenario>`), including required HCL configuration, variables, and sample registration. |
3 participants
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.