Skip to content

Send 0 values for client_ttl and default_ttl in backend service - #18971

Open
roaks3 wants to merge 1 commit into
mainfrom
ai-fix-29102
Open

Send 0 values for client_ttl and default_ttl in backend service#18971
roaks3 wants to merge 1 commit into
mainfrom
ai-fix-29102

Conversation

@roaks3

@roaks3 roaks3 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Send 0 values for cdn_policy.client_ttl and cdn_policy.default_ttl in google_compute_backend_service and google_compute_region_backend_service. Previously, configuring a TTL of 0 caused the attribute to be omitted, resulting in API server defaults and a permanent plan diff.

Fixes hashicorp/terraform-provider-google#29102

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: fixed a permanent diff in `google_compute_backend_service` and `google_compute_region_backend_service` when `cdn_policy.client_ttl` or `cdn_policy.default_ttl` is set to 0

@modular-magician

modular-magician commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b80a6c9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 66 insertions(+), 4 deletions(-)
google-beta provider View Diff 3 files changed, 66 insertions(+), 4 deletions(-)
terraform-google-conversion View Diff 5 files changed, 11 insertions(+), 8 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1560 1448 95 17
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeBackendService_backendServiceCacheIncludeHttpHeadersExample
  • TestAccComputeBackendService_backendServiceCacheSimpleExample
  • TestAccComputeBackendService_cdnPolicyZeroTtl
  • TestAccComputeBackendService_withCdnPolicy
  • TestAccComputeDisk_resourceManagerTags
  • TestAccComputeImage_resourceManagerTags
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstanceTemplate_gracefulShutdown
  • TestAccComputeInstanceTemplate_resourceManagerTags
  • TestAccComputeInstance_GracefulShutdownWithResetUpdate
  • TestAccComputeInstance_GracefulShutdownWithoutResetUpdate
  • TestAccComputeInstance_resourceManagerTags
  • TestAccComputeRegionInstanceTemplate_gracefulShutdown
  • TestAccComputeRegionInstanceTemplate_resourceManagerTags
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccComputeStoragePool_resourceManagerTags
  • TestAccComputeTargetInstance_withSecurityPolicy

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeBackendService_backendServiceCacheSimpleExample
✅ Log TestAccComputeBackendService_withCdnPolicy
✅ Log TestAccComputeDisk_resourceManagerTags
✅ Log TestAccComputeImage_resourceManagerTags
✅ Log TestAccComputeInstanceTemplate_resourceManagerTags
✅ Log TestAccComputeRegionInstanceTemplate_resourceManagerTags
✅ Log TestAccComputeStoragePool_resourceManagerTags
❌ Error · Log - TestAccComputeBackendService_backendServiceCacheIncludeHttpHeadersExample
❌ Error · Log - TestAccComputeBackendService_cdnPolicyZeroTtl
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeInstanceTemplate_gracefulShutdown
❌ Error · Log - TestAccComputeInstance_GracefulShutdownWithResetUpdate
❌ Error · Log - TestAccComputeInstance_GracefulShutdownWithoutResetUpdate
❌ Error · Log - TestAccComputeInstance_resourceManagerTags
❌ Error · Log - TestAccComputeRegionInstanceTemplate_gracefulShutdown
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccComputeTargetInstance_withSecurityPolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@roaks3 VCR tests complete for b80a6c9!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_compute_backend_service: cdn_policy client_ttl/default_ttl/max_ttl of 0 is silently dropped, causing a permanent diff

2 participants