Skip to content

discoveryengine: add search_addon_spec to google_discovery_engine_widget_config - #18962

Open
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-558780349
Open

slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-558780349

Conversation

@slevenick

Copy link
Copy Markdown
Contributor

Added field coverage for uiSettings.searchAddonSpec on google_discovery_engine_widget_config (discoveryengine:v1:WidgetConfig).

reference: b/558780349

discoveryengine: added `ui_settings.search_addon_spec` field to `google_discovery_engine_widget_config`

@slevenick

Copy link
Copy Markdown
Contributor Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 91599bf:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 163 insertions(+)
google-beta provider View Diff 4 files changed, 163 insertions(+)
terraform-google-conversion View Diff 1 file changed, 55 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
53 47 4 2
Affected Service Packages
  • discoveryengine

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccDiscoveryEngineWidgetConfig_discoveryengineWidgetconfigBasicExample_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDiscoveryEngineWidgetConfig_discoveryengineWidgetconfigBasicExample_update
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick, @ScottSuarez VCR tests complete for 91599bf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants