[Dataproc] Add instance_flexibility_policy to worker_config in google_dataproc_workflow_template - #18946
[Dataproc] Add instance_flexibility_policy to worker_config in google_dataproc_workflow_template#18946realdev12 wants to merge 1 commit into
Conversation
…_dataproc_workflow_template
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4efa86f: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataproc_workflow_template" "primary" {
placement {
managed_cluster {
config {
worker_config {
disk_config {
boot_disk_type = # value needed
}
}
}
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @realdev12, @roaks3 VCR tests complete for 4efa86f! |
|
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label |
Purpose
Add support for Dataproc Flexible VMs (
instance_flexibility_policy) toworker_configingoogle_dataproc_workflow_template. This enables workflow templates to define primary worker pools with flexible VM shapes, instance selection lists with priority ranks, and disk configurations.Implementation Scope & Design Decisions
To maintain parity with the existing
google_dataproc_clusterresource and keep this PR reviewable and well-scoped:instance_flexibility_policyonworker_configwithinstance_selection_list(priority ranking, machine types, custom disk configs) andinstance_selection_results.disk_configscope: Restricted to core disk properties (boot_disk_type,boot_disk_size_gb,num_local_ssds) to avoid unnecessary schema complexity while fully covering primary use cases.master_config, and PR 3 will addsecondary_worker_config.Tests & Verification
betaandgaproviders.TestAccDataprocWorkflowTemplate_instanceFlexibilityPolicyexercisingworker_config.instance_flexibility_policywith multiple machine selections, ranking, and disk configuration.