Skip to content

feat(speech): add multi-language transcription samples for v1 - #10373

Merged
amcolin merged 1 commit into
GoogleCloudPlatform:mainfrom
amcolin:add-speech-transcript-multilanguage-v1
Nov 6, 2026
Merged

amcolin merged 1 commit into
GoogleCloudPlatform:mainfrom
amcolin:add-speech-transcript-multilanguage-v1

Conversation

@amcolin

@amcolin amcolin commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes Internal b/575165562

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only

Compliance & Style

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample

Post-Approval Actions

  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added api: speech Issues related to the Speech-to-Text API. samples Issues that are directly related to samples. labels Nov 6, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces multi-language speech recognition capabilities, adding a new multi-language command-line option, implementing local and GCS-based transcription methods, and adding corresponding integration tests. The review feedback suggests making the test assertions more robust and less fragile by checking for the presence of "google" case-insensitively rather than matching the exact "Transcript : OK Google" string, which could change with API updates.

@amcolin
amcolin force-pushed the add-speech-transcript-multilanguage-v1 branch 2 times, most recently from 4cb2e82 to 1d5b6f3 Compare November 6, 2026 18:19
@amcolin
amcolin force-pushed the add-speech-transcript-multilanguage-v1 branch from 1d5b6f3 to 9acf7a4 Compare November 6, 2026 18:33
@amcolin
amcolin marked this pull request as ready for review November 6, 2026 18:43
@amcolin
amcolin requested review from a team and yoshi-approver as code owners November 6, 2026 18:43
@snippet-bot

snippet-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amcolin
amcolin merged commit c13abb8 into GoogleCloudPlatform:main Nov 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: speech Issues related to the Speech-to-Text API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants