feat(push_delivery,backend): cut over push delivery and RSS handler to BaseSummaryVisitor (#2622) - #2637
Merged
Merged
Conversation
jcscottiii
force-pushed
the
feat/all-saved-search-visitor-cutover
branch
from
July 21, 2026 20:05
6882b44 to
276df8f
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
2 times, most recently
from
July 21, 2026 20:10
00fb6d6 to
4637948
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-visitor-cutover
branch
2 times, most recently
from
July 21, 2026 21:10
f90c656 to
6fb0070
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
from
July 21, 2026 21:10
4637948 to
af63999
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-visitor-cutover
branch
from
July 21, 2026 21:43
6fb0070 to
d5039eb
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
2 times, most recently
from
July 22, 2026 14:01
dc5b1e8 to
ea25f1a
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-visitor-cutover
branch
from
July 22, 2026 14:01
d5039eb to
34105c8
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
from
July 22, 2026 14:58
ea25f1a to
f067369
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-visitor-cutover
branch
from
July 22, 2026 14:58
34105c8 to
74e4719
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
from
July 29, 2026 18:32
f067369 to
2bc1c07
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-visitor-cutover
branch
from
July 29, 2026 18:33
74e4719 to
f1d0da6
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
from
July 29, 2026 19:24
2bc1c07 to
df2f585
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-visitor-cutover
branch
from
July 29, 2026 19:24
f1d0da6 to
1e5a45c
Compare
neilv-g
reviewed
Jul 29, 2026
neilv-g
approved these changes
Jul 29, 2026
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
from
July 30, 2026 15:07
df2f585 to
7c94da5
Compare
…o BaseSummaryVisitor (#2622) Complete the Visitor pattern cutover across push delivery pipelines and the RSS HTTP handler. - Update shouldNotifyV1 in workers/push_delivery/pkg/dispatcher to delegate highlight filtering and error checks to EventSummary.Categorize(triggers) and BaseSummaryVisitor.HasContent(). - Cut over get_subscription_rss.go in backend/pkg/httpserver to invoke summary.Accept(visitor, triggers) for RSS feed payload generation. - Pass EventSummary by pointer (*EventSummary) into shouldNotifyV1 to avoid header and slice backing array copy overhead across subscriber iteration loops. - Remove redundant manual trigger matching logic, completing the double-dispatch cutover for push notifications and RSS feed rendering. CONV=f70d8c59-6f49-4a69-bb74-5643e908f5b1 TAG=agy
jcscottiii
force-pushed
the
feat/all-saved-search-visitor-cutover
branch
from
July 30, 2026 15:32
1e5a45c to
b1767f1
Compare
jcscottiii
changed the base branch from
feat/all-saved-search-slack-visitor-impl
to
main
July 30, 2026 15:32
jcscottiii
enabled auto-merge
July 30, 2026 17:00
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the Visitor pattern cutover across push delivery pipelines and the RSS HTTP handler.
Fixes #2622 (PR 5/5)
CONV=f70d8c59-6f49-4a69-bb74-5643e908f5b1
TAG=agy