feat(webhook): migrate Slack webhook payload builder to CategorizedSummaryVisitor (#2622) - #2636
Merged
Merged
Conversation
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
from
July 21, 2026 20:05
1d9efae to
39bcf5b
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
from
July 21, 2026 20:05
ed6a10e to
00fb6d6
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
from
July 21, 2026 20:10
39bcf5b to
3089994
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
2 times, most recently
from
July 21, 2026 21:10
4637948 to
af63999
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
from
July 21, 2026 21:10
3089994 to
c868c76
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
from
July 21, 2026 21:43
af63999 to
dc5b1e8
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
from
July 21, 2026 21:43
c868c76 to
b349e90
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
from
July 22, 2026 14:01
dc5b1e8 to
ea25f1a
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
2 times, most recently
from
July 22, 2026 14:58
0b5de95 to
b134ee3
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
from
July 22, 2026 14:58
ea25f1a to
f067369
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
from
July 29, 2026 18:30
b134ee3 to
6b4bb4e
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
from
July 29, 2026 18:32
f067369 to
2bc1c07
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
from
July 29, 2026 19:23
6b4bb4e to
09129dd
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
from
July 29, 2026 19:24
2bc1c07 to
df2f585
Compare
neilv-g
approved these changes
Jul 29, 2026
neilv-g
reviewed
Jul 29, 2026
neilv-g
approved these changes
Jul 29, 2026
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
from
July 30, 2026 13:29
09129dd to
79835df
Compare
Base automatically changed from
feat/all-saved-search-email-visitor-impl
to
main
July 30, 2026 15:02
…mmaryVisitor (#2622) Migrate the Slack webhook payload builder to the CategorizedSummaryVisitor interface and fix dropped feature notification sections. - Implement CategorizedSummaryVisitor on slackPayloadBuilder in workers/webhook/pkg/webhook, dispatching categorized highlights via EventSummary.Accept(). - Add appendRemovedFeatures and appendDeletedFeatures block builders to Slack payload construction to render missing feature removal and deletion notifications. - Add nil pointer guards in slack.go for Split, Moved, and optional Change.From.Version fields to prevent panic on partial event payloads. - Update golden JSON payload snapshots and unit tests to verify full category block rendering. CONV=f70d8c59-6f49-4a69-bb74-5643e908f5b1 TAG=agy
jcscottiii
force-pushed
the
feat/all-saved-search-slack-visitor-impl
branch
from
July 30, 2026 15:07
df2f585 to
7c94da5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the Slack webhook payload builder to the CategorizedSummaryVisitor interface and adds missing feature removal and deletion notification sections.
Fixes #2622 (PR 4/5)
CONV=f70d8c59-6f49-4a69-bb74-5643e908f5b1
TAG=agy